Support deduplication on topic level #7821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
codelipenghui
requested review from
codelipenghui,
sijie,
merlimat and
jiazhai
codelipenghui
added
component/topic-policy
doc-required
codelipenghui
approved these changes
Aug 17, 2020
|
@jianyun8023 @MarvinCai Please help review this PR. |
|
@315157973 Could you please resolve the conflicts? |
jianyun8023
reviewed
Aug 19, 2020
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Topics.java
Outdated
Show resolved
Hide resolved
|
overall lgtm |
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
### Motivation Support set `DeduplicationEnabled` on topic level ### Modifications Support set/get/remove `DeduplicationEnabled` policy on topic level. ### Verifying this change Added Unit test to verify set/get/remove `DeduplicationEnabled` policy at Topic level work as expected when Topic level policy is enabled/disabled `org.apache.pulsar.broker.service.persistent.TopicDuplicationTest`
This was referenced Aug 28, 2020
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
### Motivation Support set `DeduplicationEnabled` on topic level ### Modifications Support set/get/remove `DeduplicationEnabled` policy on topic level. ### Verifying this change Added Unit test to verify set/get/remove `DeduplicationEnabled` policy at Topic level work as expected when Topic level policy is enabled/disabled `org.apache.pulsar.broker.service.persistent.TopicDuplicationTest`
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
… topic level (apache#7918) ### Motivation PR (apache#7821) supports set/get/remove the deduplication policy at the topic level. ### Modifications Update the doc based on code updates. The following docs are updated: - Messaging: message deduplication - Manage message deduplication - pulsar admin cli reference
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
### Motivation Support set `DeduplicationEnabled` on topic level ### Modifications Support set/get/remove `DeduplicationEnabled` policy on topic level. ### Verifying this change Added Unit test to verify set/get/remove `DeduplicationEnabled` policy at Topic level work as expected when Topic level policy is enabled/disabled `org.apache.pulsar.broker.service.persistent.TopicDuplicationTest`
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
… topic level (apache#7918) ### Motivation PR (apache#7821) supports set/get/remove the deduplication policy at the topic level. ### Modifications Update the doc based on code updates. The following docs are updated: - Messaging: message deduplication - Manage message deduplication - pulsar admin cli reference
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
### Motivation Support set `DeduplicationEnabled` on topic level ### Modifications Support set/get/remove `DeduplicationEnabled` policy on topic level. ### Verifying this change Added Unit test to verify set/get/remove `DeduplicationEnabled` policy at Topic level work as expected when Topic level policy is enabled/disabled `org.apache.pulsar.broker.service.persistent.TopicDuplicationTest`
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
… topic level (apache#7918) ### Motivation PR (apache#7821) supports set/get/remove the deduplication policy at the topic level. ### Modifications Update the doc based on code updates. The following docs are updated: - Messaging: message deduplication - Manage message deduplication - pulsar admin cli reference
|
I've removed the "doc-required" label since the doc has been added here. |
Anonymitaet
removed
the
doc-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support set
DeduplicationEnabledon topic levelModifications
Support set/get/remove
DeduplicationEnabledpolicy on topic level.Verifying this change
Added Unit test to verify set/get/remove
DeduplicationEnabledpolicy at Topic level work as expected when Topic level policy is enabled/disabledorg.apache.pulsar.broker.service.persistent.TopicDuplicationTest