[Issue 7787][pulsar-client-cpp] Throw std::exception types #7798
+29
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bklyn
force-pushed
the
7787-throw-std-exception
branch
from
7d737d8 to
1b36007
Compare
|
Seems some tests are failing, but I didn't touch the Java code (CPP/Py tests are OK). |
Bklyn
force-pushed
the
7787-throw-std-exception
branch
from
a0c8d8a to
6edb98a
Compare
* Change throws of const char* to use std::exception types instead
Bklyn
force-pushed
the
7787-throw-std-exception
branch
from
6edb98a to
1d3713b
Compare
|
/pulsarbot run-failure-checks |
2 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
jiazhai
approved these changes
Aug 21, 2020
|
@jiazhai @BewareMyPower Are these sorts of transient test failures typical? Thanks for the assistance! |
|
@Bklyn Yeah, there're some flaky tests. Besides, I guess sometimes ci tests may fail because of the limited resource of docker containers. |
sijie
approved these changes
Aug 24, 2020
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
Fixes apache#7787 ### Motivation Throw std::exception instead of `const char*` ### Modifications Should be self explanatory. ### Verifying this change This change should be covered by existing tests, such as BatchMessageTest. Not sure about the Auth test which catches `...` however.
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
Fixes apache#7787 ### Motivation Throw std::exception instead of `const char*` ### Modifications Should be self explanatory. ### Verifying this change This change should be covered by existing tests, such as BatchMessageTest. Not sure about the Auth test which catches `...` however.
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
Fixes apache#7787 ### Motivation Throw std::exception instead of `const char*` ### Modifications Should be self explanatory. ### Verifying this change This change should be covered by existing tests, such as BatchMessageTest. Not sure about the Auth test which catches `...` however.
wolfstudy
pushed a commit
that referenced
this pull request
Oct 30, 2020
Fixes #7787 ### Motivation Throw std::exception instead of `const char*` ### Modifications Should be self explanatory. ### Verifying this change This change should be covered by existing tests, such as BatchMessageTest. Not sure about the Auth test which catches `...` however. (cherry picked from commit b74094e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7787
Motivation
Throw std::exception instead of
const char*Modifications
Should be self explanatory.
Verifying this change
This change should be covered by existing tests, such as BatchMessageTest. Not sure about the Auth test which catches
...however.Does this pull request potentially affect one of the following parts:
Yes
const char*now throw a type derived fromstd::exceptionDocumentation
The methods that can throw should be documented as such. This was not implemented.