make orderedExecutor threads number configurable #7765
Merged
+19
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conf/broker.conf
Outdated
| @@ -58,6 +58,9 @@ advertisedAddress= | |||
| # Number of threads to use for Netty IO. Default is set to 2 * Runtime.getRuntime().availableProcessors() | |||
| numIOThreads= | |||
|
|
|||
| # Number of threads to use for orderedExecutor. Default is 8 | |||
There was a problem hiding this comment.
Could you please add more description for the ordered executor in the broker? For example, what tasks will he be used to perform, etc?
There was a problem hiding this comment.
Thanks for your feedback. I have updated some descriptions, please take a look.
|
/pulsarbot run-failure-checks |
merlimat
reviewed
Aug 8, 2020
merlimat
reviewed
Aug 8, 2020
Co-authored-by: Matteo Merli <mmerli@apache.org>
Co-authored-by: Matteo Merli <mmerli@apache.org>
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Aug 10, 2020
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Aug 11, 2020
sijie
added
area/config
type/enhancement
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
### Motivation
The orderedExecutor number is hard code to 8 when pulsar service start, it should be configurable in broker.conf.
```
orderedExecutor = OrderedExecutor.newBuilder().numThreads(8).name("pulsar-ordered")
```
### Changes
make the orderedExecutor threads number configurable in broker.conf
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
### Motivation
The orderedExecutor number is hard code to 8 when pulsar service start, it should be configurable in broker.conf.
```
orderedExecutor = OrderedExecutor.newBuilder().numThreads(8).name("pulsar-ordered")
```
### Changes
make the orderedExecutor threads number configurable in broker.conf
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
### Motivation
The orderedExecutor number is hard code to 8 when pulsar service start, it should be configurable in broker.conf.
```
orderedExecutor = OrderedExecutor.newBuilder().numThreads(8).name("pulsar-ordered")
```
### Changes
make the orderedExecutor threads number configurable in broker.conf
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
### Motivation
The orderedExecutor number is hard code to 8 when pulsar service start, it should be configurable in broker.conf.
```
orderedExecutor = OrderedExecutor.newBuilder().numThreads(8).name("pulsar-ordered")
```
### Changes
make the orderedExecutor threads number configurable in broker.conf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The orderedExecutor number is hard code to 8 when pulsar service start, it should be configurable in broker.conf.
Changes
make the orderedExecutor threads number configurable in broker.conf