Skip to content

[Issue 7736][broker]Fix broker lookup return wrong url when specify advertised listener #7737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2020
Merged

[Issue 7736][broker]Fix broker lookup return wrong url when specify advertised listener #7737

merged 1 commit into from
Aug 5, 2020
+50 −8

Conversation

wangjialing218
Copy link
Contributor

@wangjialing218 wangjialing218 commented Aug 4, 2020 •
edited
Loading

Motivation

Fixes #7736

Modifications

In function searchForCandidateBroker(), return the url according to advertisedListenerName when the candidateBroker is not self.

@wangjialing218 wangjialing218 reopened this Aug 4, 2020
@sijie sijie requested review from codelipenghui and jiazhai August 4, 2020 05:00
@sijie sijie added this to the 2.7.0 milestone Aug 4, 2020
@sijie
Copy link
Member

sijie commented Aug 4, 2020

/pulsarbot run-failure-checks

@sijie
Copy link
Member

sijie commented Aug 4, 2020

@wangjialing218 Can you write a simple test case?

@wangjialing218
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@murong00
Copy link
Contributor

murong00 commented Aug 4, 2020

/pulsarbot run-failure-checks

@murong00
Copy link
Contributor

murong00 commented Aug 4, 2020

@sijie @wolfstudy Can this pr be cherry-picked to upcoming release 2.6.1, we also need this fix in our product env.

@wolfstudy
Copy link
Member

@sijie @wolfstudy Can this pr be cherry-picked to upcoming release 2.6.1, we also need this fix in our product env.

Sure, please make sure the Action CI pass, will cherry-pick this change to branch-2.6

@wolfstudy
Copy link
Member

/pulsarbot run-failure-checks

@wolfstudy wolfstudy requested a review from sijie August 4, 2020 14:00
@wolfstudy
Copy link
Member

@sijie @jiazhai @codelipenghui PTAL thanks

@wangjialing218
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@wangjialing218
Copy link
Contributor Author

/pulsarbot run-failure-checks

@codelipenghui codelipenghui added the type/bug The PR fixed a bug or issue reported a bug label Aug 5, 2020
@wolfstudy
Copy link
Member

@wangjialing218 Can you merge the master code to fix CI error?

@wangjialing218 wangjialing218 force-pushed the branch-fix_listener_issue branch from c58df91 to 35ad584 Compare August 5, 2020 05:49
@wangjialing218
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@wangjialing218
Copy link
Contributor Author

/pulsarbot run-failure-checks

Fix broker lookup return wrong url when specify advertised listener
644c58b 
get advertised listener name from lookup options

add test case
@wangjialing218 wangjialing218 force-pushed the branch-fix_listener_issue branch from 35ad584 to 644c58b Compare August 5, 2020 08:32
@wangjialing218
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@wangjialing218
Copy link
Contributor Author

/pulsarbot run-failure-checks

@wolfstudy wolfstudy merged commit 109c8bf into apache:master Aug 5, 2020
wolfstudy pushed a commit that referenced this pull request Aug 5, 2020
@wangjialing218 @wolfstudy
Fix broker lookup return wrong url when specify advertised listener (#…
36484df 
…7737)

get advertised listener name from lookup options

add test case

Co-authored-by: wangjialing <wangjialing@cmss.chinamobile.com>
(cherry picked from commit 109c8bf)
@wangjialing218 wangjialing218 deleted the branch-fix_listener_issue branch August 6, 2020 01:09
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
@wangjialing218 @huangdx0726
Fix broker lookup return wrong url when specify advertised listener (a…
f27d863 
…pache#7737)

get advertised listener name from lookup options

add test case

Co-authored-by: wangjialing <wangjialing@cmss.chinamobile.com>
lbenc135 pushed a commit to lbenc135/pulsar that referenced this pull request Sep 5, 2020
@wangjialing218
Fix broker lookup return wrong url when specify advertised listener (a…
e05abf9 
…pache#7737)

get advertised listener name from lookup options

add test case

Co-authored-by: wangjialing <wangjialing@cmss.chinamobile.com>
lbenc135 pushed a commit to lbenc135/pulsar that referenced this pull request Sep 5, 2020
@wangjialing218
Fix broker lookup return wrong url when specify advertised listener (a…
8d7c2d2 
…pache#7737)

get advertised listener name from lookup options

add test case

Co-authored-by: wangjialing <wangjialing@cmss.chinamobile.com>
lbenc135 pushed a commit to lbenc135/pulsar that referenced this pull request Sep 5, 2020
@wangjialing218
Fix broker lookup return wrong url when specify advertised listener (a…
85a05cb 
…pache#7737)

get advertised listener name from lookup options

add test case

Co-authored-by: wangjialing <wangjialing@cmss.chinamobile.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiazhai jiazhai

@codelipenghui codelipenghui

@sijie sijie

Assignees

@wangjialing218 wangjialing218

Labels
release/2.6.1 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

Broker did not return correct url when client specify advertisedListenerName
6 participants
@wangjialing218 @sijie @murong00 @wolfstudy @jiazhai @codelipenghui