Upgrade Presto version to 332 #7194
Merged
+276
−251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ebyhr tested this out using prestosql:presto:329 as a base image. I'm getting the following error when I start the coordinator: My catalog properties are configured as follows: fyi I have a Presto cluster using prestodb that connects fine to my pulsar cluster edit: updated link of docker version 334 --> 329 that corresponded the stacktrace. |
@dionjansen the stacktrace matches Presto 329. Can you attach the stacktrace for Presto 324 as well? |
@findepi a yes I posted the Stacktrace for 329 (I updated my original comment), did you mean Presto 324 or 334 (latest)? This is the error I got for the latest version of Presto 334 (that is: prestosql/presto:334) |
|
@dionjansen with 324, did the following happen by itself, or did you initiate it? there seems to be no exception logged and Presto thought the catalog was correct initiated ( |
You are right I am using a deployment that uses a readinessProbe So I removed the probes for now and I got a bit further. I managed to see the catalog for Logs in the coordinator: |
|
@dionjansen thanks for the update It could be that Pulsar would benefit from |
sijie
approved these changes
Jun 9, 2020
jerrypeng
approved these changes
Jun 10, 2020
jiazhai
approved these changes
Jun 11, 2020
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Jun 11, 2020
codelipenghui
approved these changes
Jun 11, 2020
There was a problem hiding this comment.
@ebyhr would you please take a look at the failed license check
|
@codelipenghui Thanks for your comment. Fixed license check failure. |
|
@ebyhr not sure if this is still relevant, but if you'd like me to test this build let me know! |
|
@dionjansen Were you able to resolve the issues with the ClassCastExceptions? I seem to be running into that same issue when trying to add the pulsar-connector to a presto deployment running v332 of prestosql |
|
@enriched I kind of let this go and postponed using prestosql for now. I was using the 2.6.0 release (I'm not sure this PR was included in that though). This is the Dockerfile I was using to test this out: ARG PRESTO_VERSION=336
FROM prestosql/presto:$PRESTO_VERSION
ARG PULSAR_MIRROR="https://archive.apache.org/dist/pulsar"
ARG PULSAR_VERSION="2.6.0"
ARG PULSAR_BIN="${PULSAR_MIRROR}/pulsar-${PULSAR_VERSION}/apache-pulsar-${PULSAR_VERSION}-bin.tar.gz"
ARG PULSAR_OFFLOADERS_BIN="${PULSAR_MIRROR}/pulsar-${PULSAR_VERSION}/apache-pulsar-offloaders-${PULSAR_VERSION}-bin.tar.gz"
ARG PRESTO_HOME="/usr/lib/presto"
USER root
RUN yum -y -q update \
&& yum -y -q install wget \
# Install pulsar presto connector
&& wget --quiet $PULSAR_BIN \
&& tar xzf apache-pulsar-${PULSAR_VERSION}-bin.tar.gz \
&& rm -rf apache-pulsar-${PULSAR_VERSION}-bin.tar.gz \
&& mv apache-pulsar-${PULSAR_VERSION}/lib/presto/plugin/pulsar-presto-connector $PRESTO_HOME/plugin \
&& rm -rf apache-pulsar-${PULSAR_VERSION} \
# Install offloaders
&& wget --quiet $PULSAR_OFFLOADERS_BIN \
&& tar xzf apache-pulsar-offloaders-${PULSAR_VERSION}-bin.tar.gz \
&& rm -rf apache-pulsar-offloaders-${PULSAR_VERSION}-bin.tar.gz \
&& mv apache-pulsar-offloaders-${PULSAR_VERSION}/offloaders $PRESTO_HOME/offloaders \
&& rm -rf apache-pulsar-offloaders-${PULSAR_VERSION} \
# Cleanup
&& yum -q clean all
EXPOSE 8080
USER presto:presto
ENV LANG en_US.UTF-8
CMD ["/usr/lib/presto/bin/run-presto"] |
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
* Upgrade Presto version to 332 * Update LICENSE file in pulsar-sql module * Wrap ClassLoaderSafeConnectorMetadata around PulsarMetadata * Update LICENSE file in pulsar-sql module
jiazhai
pushed a commit
to jiazhai/pulsar
that referenced
this pull request
Aug 26, 2020
* Upgrade Presto version to 332 * Update LICENSE file in pulsar-sql module * Wrap ClassLoaderSafeConnectorMetadata around PulsarMetadata * Update LICENSE file in pulsar-sql module (cherry picked from commit 5d02c70)
|
@dionjansen Hi, please take a look at this PR #7898, the problem you met was fixed. |
wolfstudy
added a commit
that referenced
this pull request
Oct 30, 2020
This reverts commit 2e44cb1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6605
Motivation
Modifications