New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change nondurable cursor to active #6769
change nondurable cursor to active #6769
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the right fix since it would cache even if the cursor is reading older data
@merlimat I think the cursor will be set inactive by the interval backlog check. |
@zhaorongsheng You're probably right. Let me review this more in depth tomorrow since it was a long time since I touched it. |
OK. Thanks~ |
/pulsarbot run-failure-checks |
### Motivation When use non-durable subscription the cursor is not active which lead to the written entries are not put into cache. This situation would degrade reading performance. ### Modifications Change the `NonDurableCursorImpl` to active and remove the three override methods: `setActive()/isActive()/setInactive()` ### Verifying this change This change added tests and can be verified as follows: *ManagedCursorTest.testNonDurableCursorActive()* - add test to check `NonDurableCursorImpl` activity
### Motivation When use non-durable subscription the cursor is not active which lead to the written entries are not put into cache. This situation would degrade reading performance. ### Modifications Change the `NonDurableCursorImpl` to active and remove the three override methods: `setActive()/isActive()/setInactive()` ### Verifying this change This change added tests and can be verified as follows: *ManagedCursorTest.testNonDurableCursorActive()* - add test to check `NonDurableCursorImpl` activity (cherry picked from commit 16ab351)
### Motivation When use non-durable subscription the cursor is not active which lead to the written entries are not put into cache. This situation would degrade reading performance. ### Modifications Change the `NonDurableCursorImpl` to active and remove the three override methods: `setActive()/isActive()/setInactive()` ### Verifying this change This change added tests and can be verified as follows: *ManagedCursorTest.testNonDurableCursorActive()* - add test to check `NonDurableCursorImpl` activity
### Motivation When use non-durable subscription the cursor is not active which lead to the written entries are not put into cache. This situation would degrade reading performance. ### Modifications Change the `NonDurableCursorImpl` to active and remove the three override methods: `setActive()/isActive()/setInactive()` ### Verifying this change This change added tests and can be verified as follows: *ManagedCursorTest.testNonDurableCursorActive()* - add test to check `NonDurableCursorImpl` activity
Motivation
When use non-durable subscription the cursor is not active which lead to the written entries are not put into cache. This situation would degrade reading performance.
Modifications
Change the
NonDurableCursorImpl
to active and remove the three override methods:setActive()/isActive()/setInactive()
Verifying this change
This change added tests and can be verified as follows:
ManagedCursorTest.testNonDurableCursorActive()
NonDurableCursorImpl
activity