Skip to content

[pulsar-client] Fix broken replication msg to specific cluster #4930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2019
Merged

[pulsar-client] Fix broken replication msg to specific cluster #4930

merged 1 commit into from
Aug 12, 2019
+42 −0

Conversation

rdhabalia
Copy link
Contributor

Motivation

Right now, pulsar-client-java doesn't set replicator_to into message when batching is enabled so, user wants to use feature to replicate message to specific colo is broken.

Modification

Set the replicate_to field and added test to verify the fix.

@rdhabalia rdhabalia added this to the 2.4.1 milestone Aug 9, 2019
@rdhabalia rdhabalia self-assigned this Aug 9, 2019
@sijie
Copy link
Member

sijie commented Aug 10, 2019

// org.apache.maven.surefire.booter.SurefireBooterForkException: ExecutionException The forked VM terminated without properly saying goodbye. VM crash or System.exit called?

run java8 tests

@sijie sijie merged commit 02f9fd3 into apache:master Aug 12, 2019
@rdhabalia rdhabalia deleted the repl_to branch August 22, 2019 18:37
jiazhai pushed a commit that referenced this pull request Aug 28, 2019
@rdhabalia @jiazhai
[pulsar-client] Fix broken replication msg to specific cluster (#4930)
036be6f 
(cherry picked from commit 02f9fd3)
@k2la k2la mentioned this pull request Jan 30, 2021
Merged
sijie pushed a commit that referenced this pull request Feb 1, 2021
@k2la
[pulsar-client-cpp] Fix broken replication msg to specific cluster (#…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
6c914d4 
…9372)

Same as #4930 .
codelipenghui pushed a commit that referenced this pull request Feb 4, 2021
@k2la @codelipenghui
[pulsar-client-cpp] Fix broken replication msg to specific cluster (#…
d48a575 
…9372)

Same as #4930 .

(cherry picked from commit 6c914d4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie

@merlimat merlimat

@jiazhai jiazhai

@jai1 jai1

@saandrews saandrews

@nkurihar nkurihar

Assignees

@rdhabalia rdhabalia

Labels
area/client
Projects
None yet
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rdhabalia @sijie