expose getLastMessageId method in ConsumerImpl #4911
Merged
+517
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
reviewed
Aug 10, 2019
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiMessageIdImpl.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiMessageIdImpl.java
Show resolved
Hide resolved
|
@sijie Thanks. updated following your comments. |
|
run java8 tests |
sijie
reviewed
Aug 13, 2019
|
|
||
| int currentResult = entry.getValue().compareTo(otherMessage); | ||
| if (result == 0) { | ||
| result = currentResult; |
There was a problem hiding this comment.
I think the logic here is problematic. This resets the result back to latest result.
a MultipleMessageId is larger than the other one is when all the partitions' messageId is larger or equals to the messageIds, no?
There was a problem hiding this comment.
- result == 0 && currentResult ==0, then this reset has no effect.
- result ==0 && currentResult !=0, then we keep the non-zero result, this is the result that may be finally returned.
sijie
approved these changes
Aug 14, 2019
codelipenghui
approved these changes
Aug 16, 2019
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiMessageIdImpl.java
Show resolved
Hide resolved
wolfstudy
pushed a commit
that referenced
this pull request
Nov 20, 2019
Fixes #4909 ### Motivation It would be good to expose method `getLastMessageId` in `ConsumerImpl` to a public method. eg. some times user would like to know the lag messages; or only consume messages before current time. ### Modifications - expose method `getLastMessageId` in consumer api. - add unit test. ### Verifying this change Ut passed (cherry picked from commit 93d95c7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4909
Motivation
It would be good to expose method
getLastMessageIdinConsumerImplto a public method.eg. some times user would like to know the lag messages; or only consume messages before current time.
Modifications
getLastMessageIdin consumer api.Verifying this change
Ut passed