Skip to content

Add support of pulsar-kafka-adapter for kafka-0.9 api #4886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 6, 2019

Conversation

fxbing
Copy link
Contributor

@fxbing fxbing commented Aug 5, 2019

Fixes #4791

Motivation

Currently the Pulsar Kafka wrapper is using Kafka 0.10.x version. However, there are users who use legacy-kafka version in their system and willing to move to pulsar. This PR provides pulsar-kafka adapter for kafka-api-version 0.9.X. So, this adapter can help users in their migration process from kafka-0.9 to pulsar.

Copy link
Member

@sijie sijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assumed that this is a copy for exsiting modules and changed the dependencies to 0.9.0.

Although we can think about a better to support different versions of Kafka in future.

@sijie sijie added area/client component/kafka type/feature The PR added a new feature or issue requested a new feature labels Aug 5, 2019
@sijie sijie added this to the 2.5.0 milestone Aug 5, 2019
@sijie
Copy link
Member

sijie commented Aug 5, 2019

// org.apache.pulsar.functions.worker.PulsarFunctionStateTest (#4887)

run java8 tests

Copy link
Member

@jiazhai jiazhai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

over all lgtm. Since most of the logic is similar to 0.10. It would be better to re-use the same logic and code, so it will reduce code duplication, and make it easy to maintain.

sijie added 2 commits August 5, 2019 18:28

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.
@sijie
Copy link
Member

sijie commented Aug 6, 2019

run integration tests

@sijie sijie merged commit f6ed037 into apache:master Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/client type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pulsar Kafka wrapper support Kafka 0.9.x version
3 participants