-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Add support of pulsar-kafka-adapter for kafka-0.9 api #4886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assumed that this is a copy for exsiting modules and changed the dependencies to 0.9.0.
Although we can think about a better to support different versions of Kafka in future.
// org.apache.pulsar.functions.worker.PulsarFunctionStateTest (#4887) run java8 tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
over all lgtm. Since most of the logic is similar to 0.10. It would be better to re-use the same logic and code, so it will reduce code duplication, and make it easy to maintain.
run integration tests |
Fixes #4791
Motivation
Currently the Pulsar Kafka wrapper is using Kafka 0.10.x version. However, there are users who use legacy-kafka version in their system and willing to move to pulsar. This PR provides pulsar-kafka adapter for kafka-api-version 0.9.X. So, this adapter can help users in their migration process from kafka-0.9 to pulsar.