Merge Request for #4809: provide a convenient method for C++ client producer batch container #4885
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 5, 2019 10:21
…vide a convenient method callBack(const pulsar::Result& r), which directly invoke the pulsar::BatchMessageContainer::sendCallback_(r, pulsar::BatchMessageContainer::message_);
…vide a convenient method callBack(const pulsar::Result& r), which directly invoke the pulsar::BatchMessageContainer::sendCallback_(r, pulsar::BatchMessageContainer::message_);
…tainer, change iteration way.
|
// org.apache.pulsar.functions.worker.PulsarFunctionStateTest.testPulsarFunctionState (#4887) run java8 tests |
|
@sijie I updated the description of this MR, add some simple messages about the thinking of the new method. |
sijie
approved these changes
Aug 6, 2019
|
Some more updates in the description. |
|
Change the Milestone to 2.4.2, because of conflict. |
wolfstudy
pushed a commit
that referenced
this pull request
Nov 20, 2019
…roducer batch container (#4885) provide a convenient method for C++ client producer batch container #4809 Formally the container element must be used like the following way: `MessageContainerList::iterator iter = messagesContainerListPtr->begin();` `iter->sendCallback_(r, iter->message_);` There are totally 3 reference operation steps inside: 1. Reference an exact element of MessageContainer explicitly from outside by iteration operator; 2. Reference the `sendCallback_` function pointer of said MessageContainer element explicitly from outside; 3. Reference the `message_` member of said MessageContainer element explicitly from outside; Besides, there is only one incoming variable say `Result r` is given from outside; In an ideal design, a user of `MessageContainer` should not have to know exactly the existence of `MessageContainer::sendCallback_` or `MessageContainer::message_`, what they exactly are, either how to use them. Organize those stuff in a right way, should be the responsibility of struct `MessageContainer` itself. So a reasonable convenient invoking method should be like: `MessageContainerList::iterator iter = messagesContainerListPtr->begin();` `iter->callBack(r);` And said `MessageContainer::callBack` function shall be implemented like below: `void callBack(const pulsar::Result& r) { sendCallback_(r, message_); }` Obviously, said convenient method is also an efficient one. Moreover, use a more efficient iteration method while going through the MessageContainerList; From some benchmark test result in my local environment, such "for iteration based a fixed-length", will be 5 times faster than the STL::iterator operator way. Refer to the change on BatchMessageContainer.cc, please. (cherry picked from commit 8058775)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
provide a convenient method for C++ client producer batch container #4809
Formally the container element must be used like the following way:
MessageContainerList::iterator iter = messagesContainerListPtr->begin();iter->sendCallback_(r, iter->message_);There are totally 3 reference operation steps inside:
sendCallback_function pointer of said MessageContainer element explicitly from outside;message_member of said MessageContainer element explicitly from outside;Besides, there is only one incoming variable say
Result ris given from outside;In an ideal design, a user of
MessageContainershould not have to know exactly the existence ofMessageContainer::sendCallback_orMessageContainer::message_, what they exactly are, either how to use them. Organize those stuff in a right way, should be the responsibility of structMessageContaineritself.So a reasonable convenient invoking method should be like:
MessageContainerList::iterator iter = messagesContainerListPtr->begin();iter->callBack(r);And said
MessageContainer::callBackfunction shall be implemented like below:void callBack(const pulsar::Result& r) { sendCallback_(r, message_); }Obviously, said convenient method is also an efficient one.
Moreover, use a more efficient iteration method while going through the MessageContainerList;
From some benchmark test result in my local environment, such "for iteration based a fixed-length", will be 5 times faster than the STL::iterator operator way.
Refer to the change on BatchMessageContainer.cc, please.