Enforce checkstyle in the pulsar sql module #4882
Merged
+499
−356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
approved these changes
Aug 5, 2019
|
// flaky test #4884 run cpp tests |
jiazhai
approved these changes
Aug 5, 2019
sijie
added
area/sql
jiazhai
pushed a commit
that referenced
this pull request
Aug 28, 2019
The checksyle plugin was added to the pulsar sql module to enforce the defined style. All violations were fixed: - Ordering of imports. - Formatting of the code. - Absent Javadoc comments. - Other small issues. (cherry picked from commit f6fee1c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications
The checksyle plugin was added to the pulsar sql module to enforce the defined style. All violations were fixed: