Merge Request for #4808: TYPO in C++ client producer method for processing failure case, and add corresponding unit test case. #4873
+53
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 2, 2019 15:31
…with the GIVEN result, but not a CERTAIN result.
|
|
sijie
approved these changes
Aug 5, 2019
|
// Invalid color configuration option [enabled]. Supported values are (auto|always|never). run integration tests // Build timed out (after 400 minutes). Marking the build as aborted. run java8 tests |
jiazhai
approved these changes
Aug 5, 2019
jiazhai
pushed a commit
that referenced
this pull request
Aug 28, 2019
…ssing failure case, and add corresponding unit test case. (#4873) Definitely, this is a typo. This method is dealing with the Failed Message with the GIVEN result, but not a CERTAIN result. Contribution Checklist #4808 : TYPO in C++ client producer method for processing failure case Add c++ client producer failure message unit test case. UT passed: BatchMessageTest (cherry picked from commit b90b4ea)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definitely, this is a typo. This method is dealing with the Failed Message with the GIVEN result, but not a CERTAIN result.
Contribution Checklist
#4808 : TYPO in C++ client producer method for processing failure case
Add c++ client producer failure message unit test case.
UT passed:
BatchMessageTest