[pulsar-io-jdbc] no action set as insert #4862
Merged
+58
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yittg
changed the title
|
Maybe a little more discussion need about whether swallow UNKNOWN action error or export it and trigger fail ack. |
I think it is more appropriate to throw an exception |
|
@tuteng yeah, agree with this. i prefer to expose it also. |
yittg
force-pushed
the
fix-pulsar-io-jdbc-not-set-action
branch
from
7ad410b to
3850047
Compare
sijie
approved these changes
Aug 1, 2019
|
run cpp tests |
sijie
added
area/connector
type/enhancement
|
@sijie this PR need to be merged manually? |
jiazhai
approved these changes
Aug 2, 2019
|
@yittg thank you for your contribution! |
jiazhai
pushed a commit
that referenced
this pull request
Aug 28, 2019
### Motivation jdbc sink treat all record as INSERT before #4358 , now it requires an indispensable action property which seems to be a break change, and we can deal records without any action property as INSERT. ### Modifications treat action not set as INSERT action like before. (cherry picked from commit d8356d8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
jdbc sink treat all record as INSERT before #4358 , now it requires an indispensable action property which seems to be a break change, and we can deal records without any action property as INSERT.
Modifications
treat action not set as INSERT action like before.
Verifying this change
This change is already covered by existing tests, such as TestInsertAction.
This change added tests and can be verified as follows: TestNoAction
Does this pull request potentially affect one of the following parts:
Documentation