[schema] KeyValue schema support using AUTO_CONSUME as key/value schema #4839
+425
−140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Motivation* Currently fetching schema information is done synchronously. It is called in netty callback threads and will potentially block async operations. *Modifications* Make most of the operations asynchronously in SchemaInfoProvider.
*Motivation* Currently KeyValue schema doesn't support using AUTO_CONSUME. This PR is to add this support. This PR is based on apache#4836 *Changes* - refactor a bit on Schema interface to support fetching schema info for both AutoConsumeSchema and KeyValueSchema before subscribing - add AUTO_CONSUME support to KeyValueSchema - add tests
sijie
added
type/feature
codelipenghui
approved these changes
Jul 29, 2019
| .topic(topic) | ||
| .subscriptionName("sub2") | ||
| .subscriptionInitialPosition(SubscriptionInitialPosition.Earliest) | ||
| .subscribe(); |
There was a problem hiding this comment.
Will c2 be reject by broker? default is use exclusive subscription mode.
There was a problem hiding this comment.
No because they are using different subscription names
jiazhai
approved these changes
Jul 29, 2019
|
run Integration Tests |
congbobo184
approved these changes
Jul 30, 2019
|
mark 2.4.1 for conflict #4962 |
jiazhai
pushed a commit
that referenced
this pull request
Aug 28, 2019
…ema (#4839) *Motivation* Currently KeyValue schema doesn't support using AUTO_CONSUME. This PR is to add this support. This PR is based on #4836 *Changes* - refactor a bit on Schema interface to support fetching schema info for both AutoConsumeSchema and KeyValueSchema before subscribing - add AUTO_CONSUME support to KeyValueSchema - add tests (cherry picked from commit dd7cc89)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently KeyValue schema doesn't support using AUTO_CONSUME.
This PR is to add this support.
This PR is based on #4836
Changes