Skip to content

Fix concurrent access of uninitializedCursors in ManagedLedgerImpl.asyncOpenCursor #4837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2019
Merged

Fix concurrent access of uninitializedCursors in ManagedLedgerImpl.asyncOpenCursor #4837

merged 2 commits into from
Aug 5, 2019
+88 −2

Conversation

kezhuw
Copy link
Member

@kezhuw kezhuw commented Jul 28, 2019 •
edited
Loading

Motivation

Fix concurrent access of uninitializedCursors in ManagedLedgerImpl.asyncOpenCursor.

Modifications

  • Adds test to expose concurrent access of uninitializedCursors in ManagedLedgerImpl.asyncOpenCursor.
  • Fixes concurrent access of uninitializedCursors in ManagedLedgerImpl.asyncOpenCursor.

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • Adds test to expose concurrent access of uninitializedCursors in ManagedLedgerImpl.asyncOpenCursor.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: ( no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

Sorry, something went wrong.

@sijie
Copy link
Member

sijie commented Aug 1, 2019

run cpp tests

@sijie sijie added component/storage type/bug The PR fixed a bug or issue reported a bug labels Aug 1, 2019
@sijie sijie added this to the 2.4.1 milestone Aug 1, 2019
@sijie
Copy link
Member

sijie commented Aug 1, 2019

run cpp tests

1 similar comment
@kezhuw
Copy link
Member Author

kezhuw commented Aug 3, 2019

run cpp tests

@sijie sijie merged commit 5bf319e into apache:master Aug 5, 2019
jiazhai pushed a commit that referenced this pull request Aug 28, 2019
@kezhuw @jiazhai
Fix concurrent access of uninitializedCursors in `ManagedLedgerImpl…
553a862 
….asyncOpenCursor` (#4837)

### Motivation
Fix concurrent access of `uninitializedCursors` in `ManagedLedgerImpl.asyncOpenCursor`.

### Modifications
* Adds test to expose concurrent access of `uninitializedCursors` in `ManagedLedgerImpl.asyncOpenCursor`.
* Fixes concurrent access of `uninitializedCursors` in `ManagedLedgerImpl.asyncOpenCursor`.
(cherry picked from commit 5bf319e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie

Assignees

@kezhuw kezhuw

Labels
type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kezhuw @sijie