Skip to content

Allow resource overcommitting when running functions in Kubernetes #4829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 5, 2019

Conversation

jerrypeng
Copy link
Contributor

Motivation

Currently, when running Pulsar Functions, Sources, and Sinks in Kubernetes. The resources requests and resource limits are set to the same values. While this is ok and everything will run as it should, actual resource utilization in the cluster might be low. To increase actual resource utilization, we need to be able to overcommit a certain amount in our clusters

@jerrypeng jerrypeng added this to the 2.5.0 milestone Jul 26, 2019
@jerrypeng jerrypeng requested review from merlimat and sijie July 26, 2019 19:52
@jerrypeng jerrypeng self-assigned this Jul 26, 2019
@jerrypeng
Copy link
Contributor Author

rerun cpp tests

1 similar comment
@jerrypeng
Copy link
Contributor Author

rerun cpp tests

Copy link
Member

@sijie sijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good to me. Can you add validation to make sure people don't set zero or negative numbers for these settings?

@jerrypeng
Copy link
Contributor Author

jerrypeng commented Jul 31, 2019

@sijie currently we don't have any validation logic for any function worker configs. We definitely should add that validation logic. Preferably using the annotation based validation framework I introduced before. Lets create an issue for this to add validation framework for worker configs, since currently there is nothing of there. For this PR, lets not add a one off check just for that config.

@jerrypeng
Copy link
Contributor Author

I don't think there is validation for any of the broker config as well :/

@sijie
Copy link
Member

sijie commented Jul 31, 2019

Lets create an issue for this to add validation framework for worker configs, since currently there is nothing of there. For this PR, lets not add a one off check just for that config.

Please create the issue and link it here and add a TODO item with the link to the newly added fields. So we don't forget about it.

@sijie sijie merged commit c7b2cb3 into apache:master Aug 5, 2019
jerrypeng added a commit to jerrypeng/incubator-pulsar that referenced this pull request Dec 17, 2019
…pache#4829)

Currently, when running Pulsar Functions, Sources, and Sinks in Kubernetes. The resources requests and resource limits are set to the same values.  While this is ok and everything will run as it should, actual resource utilization in the cluster might be low.   To increase actual resource utilization, we need to be able to overcommit a certain amount in our clusters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants