Add the schema admin api #4800
Merged
Add the schema admin api #4800
+506
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run Integration Tests |
|
run Integration Tests |
1 similar comment
|
run Integration Tests |
sijie
reviewed
Jul 26, 2019
| @ApiResponse(code = 401, message = "Client is not authorized or Don't have admin permission"), | ||
| @ApiResponse(code = 403, message = "Client is not authenticated"), | ||
| @ApiResponse(code = 404, message = "Tenant or Namespace or Topic doesn't exist; or Schema is not found for this topic"), | ||
| @ApiResponse(code = 412, message = "Failed to find the ownership for the topic"), |
| if (isNull(schemas)) { | ||
| response.resume(Response.status(Response.Status.NOT_FOUND).build()); | ||
| } else if (schemas.size() == 0) { | ||
| response.resume(Response.status(Response.Status.NOT_FOUND).build()); |
There was a problem hiding this comment.
should we return ok with an empty list? or do you have any thought about returning NOT_FOUND?
| Response.ok() | ||
| .encoding(MediaType.APPLICATION_JSON) | ||
| .entity(GetAllVersionsSchemaResponse.builder().getSchemaResponses( | ||
| schemas.stream().map(schemaAndMetadata -> GetSchemaResponse.builder() |
There was a problem hiding this comment.
Can you extract the schemaAndMetadata to GetSchemaResponse transformation into a common method? I think it should be reused across this class.
|
|
||
| String schemaId = buildSchemaId(tenant, namespace, topic); | ||
|
|
||
| SchemaCompatibilityStrategy schemaCompatibilityStrategy =SchemaCompatibilityStrategy |
There was a problem hiding this comment.
Suggested change
| SchemaCompatibilityStrategy schemaCompatibilityStrategy =SchemaCompatibilityStrategy | |
| SchemaCompatibilityStrategy schemaCompatibilityStrategy = SchemaCompatibilityStrategy |
OK, I will add tests and fix these problems from your comment |
|
run Integration Tests |
sijie
approved these changes
Jul 29, 2019
|
Change the Milestone to 2.4.2, because of conflict. |
wolfstudy
pushed a commit
that referenced
this pull request
Nov 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Continue the issues of #4782
Verifying this change
Add the tests for it
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (yes)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)
Documentation
Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation