[Issue 4480] Support setting zk chroot path when initialize cluster metadata #4502
+54
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiazhai
reviewed
Jun 11, 2019
| @@ -93,7 +92,7 @@ | |||
| private String globalZookeeper; | |||
|
|
|||
| @Parameter(names = { "-cs", | |||
| "--configuration-store" }, description = "Configuration Store connection string", required = false) | |||
| "--configuration-store" }, description = "Configuration Store connection string", required = true) | |||
There was a problem hiding this comment.
Hi @murong00, Is this change necessary?
There was a problem hiding this comment.
If someone missed this option, it will print error Configuration store address argument is required (--configuration-store) since --global-zookeeper option is hidden . So it may be better to make this option required.
sijie
reviewed
Jun 11, 2019
| @@ -273,6 +270,29 @@ public static void main(String[] args) throws Exception { | |||
| log.info("Cluster metadata for '{}' setup correctly", arguments.cluster); | |||
| } | |||
|
|
|||
| private static ZooKeeper initZk(String connection, int sessionTimeout) throws Exception { | |||
There was a problem hiding this comment.
@murong00 can you rewrite unit tests for this method?
sijie
approved these changes
Jun 12, 2019
|
@jiazhai can you review this again? |
jiazhai
approved these changes
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #4480
Modifications
Create the zookeeper chroot path at first if it doesn't exist.