New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SUREFIRE-1564] ensure provider dependencies can be overriden #193
[SUREFIRE-1564] ensure provider dependencies can be overriden #193
Conversation
…fintion or through project dependencies (in this order to let the plugin force a transitive dependency of the test stack), fixes the fact JUnit 5 integration is broken with 5.3.0 release
Prior to this commit, Surefire was still using JUnit Platform version 1.2.0 and Jupiter/Vintage version 5.2.0 -- now Surefire picks up the correct version, 1.3.0 and 5.3.0, to launch the Platform successfully. This is achieved by setting explicit Surefire plugin dependencies. See also apache/maven-surefire#193
You may already override the JUnit Platform and Engine versions by supplying plugin dependency definitions. See |
@sormuras: this doesnt work - you can check on meecrowave (junit module) project because classpath ignores both peoject and plugin dependencies so you end up using plugin build dependencies for part of the stack. |
@sormuras @rmannibucau |
@Tibor17 cause you don't want to put the dependency in the project at all since it is about the platform and surefire integration, not the project itself. Even the engine shouldn't be in the project dependencies, only the API. Also this was the way junit5 surefire plugin was done before the donation ;). |
@sormuras |
Solved for meecrowave via apache/openwebbeans-meecrowave#11 At least two things are still open:
|
@mureinik reported a side-effect with |
The solution is to understand the root cause after the analysis has been
done. We should start with observing classpath. Why it is different with
reused forks.
…On Thu, Sep 6, 2018 at 11:39 PM Christian Stein ***@***.***> wrote:
@mureinik <https://github.com/mureinik> reported a side-effect with
reuseForks=false over at junit-team/junit5#1579
<junit-team/junit5#1579> -- does this PR also
fixes this issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#193 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA_yRzxUHuC7bL7lbQfcuRXA9QgYCzB6ks5uYZYogaJpZM4WZuXq>
.
|
@rmannibucau |
@rmannibucau |
@rmannibucau |
Just to chime in as we are as well hit by this exact problem in https://github.com/flowable/flowable-engine/tree/master/modules/flowable-cxf. I've tried doing the exact thing that @sormuras did with apache/openwebbeans-meecrowave#11, but it didn't work. I have not tried it but I think that if one puts |
….22.0 and reuseForks=true Surefire issue: https://issues.apache.org/jira/browse/SUREFIRE-1564 Possible fix for 2.22.1 surefire: apache/maven-surefire#193
@rmannibucau |
either by the plugin definition or through project dependencies (in this order to let the plugin force a transitive dependency of the test stack), fixes the fact JUnit 5 integration is broken with 5.3.0 release