[KYUUBI #5957] Flink engine should not load kyuubi-defaults.conf #6455
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6455 +/- ##
============================================
- Coverage 58.43% 58.40% -0.04%
Complexity 24 24
============================================
Files 656 656
Lines 40267 40267
Branches 5498 5498
============================================
- Hits 23530 23517 -13
- Misses 14227 14234 +7
- Partials 2510 2516 +6 ☔ View full report in Codecov by Sentry. |
wForget
approved these changes
Jun 6, 2024
pan3793
changed the title
pan3793
added a commit
that referenced
this pull request
Jun 6, 2024
# 🔍 Description This is the root cause of #5957. Which is accidentally introduced in b315123, thus affects 1.8.0, 1.8.1， 1.8.2, 1.9.0, 1.9.1. `kyuubi-defaults.conf` is kind of a server side configuration file, all Kyuubi confs engine required should be passed via CLI args to sub-process. ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 Pass GHA. --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6455 from pan3793/flink-conf-load. Closes #5957 2972fbc [Cheng Pan] Flink engine should not load kyuubi-defaults.conf Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit fe5377e) Signed-off-by: Cheng Pan <chengpan@apache.org>
pan3793
added a commit
that referenced
this pull request
Jun 6, 2024
# 🔍 Description This is the root cause of #5957. Which is accidentally introduced in b315123, thus affects 1.8.0, 1.8.1， 1.8.2, 1.9.0, 1.9.1. `kyuubi-defaults.conf` is kind of a server side configuration file, all Kyuubi confs engine required should be passed via CLI args to sub-process. ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 Pass GHA. --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6455 from pan3793/flink-conf-load. Closes #5957 2972fbc [Cheng Pan] Flink engine should not load kyuubi-defaults.conf Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit fe5377e) Signed-off-by: Cheng Pan <chengpan@apache.org>
|
Thanks, merged to master/1.9.2/1.8.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
This is the root cause of #5957. Which is accidentally introduced in b315123, thus affects 1.8.0, 1.8.1， 1.8.2, 1.9.0, 1.9.1.
kyuubi-defaults.confis kind of a server side configuration file, all Kyuubi confs engine required should be passed via CLI args to sub-process.Types of changes 🔖
Test Plan 🧪
Pass GHA.
Checklist 📝
Be nice. Be informative.