Skip to content

KAFKA-3043: Replace request.required.acks with acks in docs. #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

sasakitoa
Copy link
Contributor

In Kafka 0.9, request.required.acks=-1 which configration of producer is replaced by acks=all,
but this old config is remained in docs.

Verified

This commit was signed with the committer’s verified signature.
tido64 Tommy Nguyen
@@ -106,8 +106,8 @@
<td>min.insync.replicas</td>
<td>1</td>
<td>min.insync.replicas</td>
<td>When a producer sets request.required.acks to -1, min.insync.replicas specifies the minimum number of replicas that must acknowledge a write for the write to be considered successful. If this minimum cannot be met, then the producer will raise an exception (either NotEnoughReplicas or NotEnoughReplicasAfterAppend).
When used together, min.insync.replicas and request.required.acks allow you to enforce greater durability guarantees. A typical scenario would be to create a topic with a replication factor of 3, set min.insync.replicas to 2, and produce with request.required.acks of -1. This will ensure that the producer raises an exception if a majority of replicas do not receive a write.</td>
<td>When a producer sets acks to all, min.insync.replicas specifies the minimum number of replicas that must acknowledge a write for the write to be considered successful. If this minimum cannot be met, then the producer will raise an exception (either NotEnoughReplicas or NotEnoughReplicasAfterAppend).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all should be in quotes, since it is an exact string value. "all".

@gwenshap
Copy link
Contributor

thanks for the contribution. Just a minor correction.

@sasakitoa
Copy link
Contributor Author

Thank you for review, @gwenshap.
I revised it.

@asfgit asfgit closed this in d9ddc10 Dec 27, 2015
@gwenshap
Copy link
Contributor

LGTM. Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants