Skip to content

how to prevent be crashed in croaringbitmap #3791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

how to prevent be crashed in croaringbitmap #3791

wants to merge 2 commits into from

Conversation

BabySid
Copy link
Contributor

@BabySid BabySid commented Jun 6, 2020

issue #3788

Simply speaking, This problem is caused by inconsistency between compiler and runtime host.
The solution is verified in the docker environment, and other environment solutions are similar.

In docker, The compiled third-party library is located in directory /var/local/thirdparty/installed.
We need replace the library libroaring.a

How to Fix

  • cd the directroy which incubator-doris is located. e.g. my incubator-doris is in /home/doris/
cd /home/doris/incubator-doris
  • modify the script to rebuild third-party
cd thirdparty
vi build-thirdparty.sh

find the function build_croaringbitmap and set ROARING_DISABLE_NATIVE=ON

......
$CMAKE_CMD -v -DROARING_BUILD_STATIC=ON -DCMAKE_INSTALL_PREFIX=$TP_INSTALL_DIR \
     -DCMAKE_INCLUDE_PATH="$TP_INSTALL_DIR/include" \
     -DENABLE_ROARING_TESTS=OFF \
     -DROARING_DISABLE_NATIVE=ON \
     -DCMAKE_LIBRARY_PATH="$TP_INSTALL_DIR/lib;$TP_INSTALL_DIR/lib64" ..
     make -j$PARALLEL && make install
......

only keep the compilation of croaringbitmap:

#build_libevent
#...
build_croaringbitmap
#...
#build_cctz
  • rebuild third-party
    In directory thirdparty
sh build-thirdparty.sh

Then u can find the new libroaring.a in the installed directory. just copy it and replace the old one

cp installed/lib/libroaring.a /var/local/thirdparty/installed/lib

Before replace the old, just rememeber backup it.

@BabySid BabySid changed the title fix compilation parameters to prevent be crash how to prevent be crashed in croaringbitmap Jun 6, 2020
@chaoyli chaoyli self-requested a review June 16, 2020 02:55
@chaoyli
Copy link
Contributor

chaoyli commented Jun 16, 2020

It seems a common problem when build. You can add it into docs/zh-CN/installing/install-deploy.md and docs/en/installing/install-deploy.md

@chaoyli chaoyli self-assigned this Jun 16, 2020
@EmmyMiao87 EmmyMiao87 added the kind/chore Issues or PRs related to compile and install label Jul 14, 2020
@morrySnow morrySnow closed this Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/chore Issues or PRs related to compile and install
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants