[FLINK-9031] Fix DataSet Union operator translation bug. #5742
+244
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds a pass over the pre-optimized plan that fixes the output strategy of union nodes to FORWARD.
StephanEwen
approved these changes
Mar 22, 2018
| /** | ||
| * FilterFunction for optimizer tests. | ||
| */ | ||
| public class IdentityFilter<T> implements FilterFunction<T> { |
There was a problem hiding this comment.
How about just using lambdas (filter always works) instead of adding this class?
There was a problem hiding this comment.
Good point.
Didn't think about that as the other tests follow that pattern.
Will remove the class.
|
The fix is still broken. Some tests are failing. |
|
Updated the PR. |
|
Thanks for updating this. Merging this... |
StephanEwen
pushed a commit
to StephanEwen/flink
that referenced
this pull request
Mar 27, 2018
- Adds a pass over the pre-optimized plan that fixes the output strategy of union nodes to FORWARD. This closes apache#5742
asfgit
pushed a commit
that referenced
this pull request
Apr 4, 2018
- Adds a pass over the pre-optimized plan that fixes the output strategy of union nodes to FORWARD. This closes #5742
sampathBhat
pushed a commit
to sampathBhat/flink
that referenced
this pull request
Jul 26, 2018
- Adds a pass over the pre-optimized plan that fixes the output strategy of union nodes to FORWARD. This closes apache#5742
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
JobGraphGeneratorbecause theJobGraphGeneratorassumed that Union nodes would always have outgoing FORWARD strategies.Brief change log
JobGraphGeneratorto fail if a union node with non-FORWARD outgoing strategy is found.Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation