Skip to content

[FLINK-13869][table-planner-blink][hive] Hive functions can not work in blink planner stream mode #10013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 30, 2019
Merged

[FLINK-13869][table-planner-blink][hive] Hive functions can not work in blink planner stream mode #10013

merged 3 commits into from
Oct 30, 2019
+116 −62

Conversation

JingsongLi
Copy link
Contributor

@JingsongLi JingsongLi commented Oct 28, 2019 •
edited
Loading

What is the purpose of the change

Fix "Hive functions can not work in blink planner stream mode"
isTableAggregate should get function instead of makeFunction.

The hive function should been make by correct constants and argTypes. Otherwise it will throw an exception. (See HiveAggSqlFunction)
In this isTableAggregate, it just want to check the aggregate function class type, so the better way is get the function instead of make a function.

Verifying this change

HiveCatalogUseBlinkITCase

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 28, 2019 •
edited
Loading

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit b29714c (Wed Dec 04 14:52:40 UTC 2019)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 28, 2019 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build

@JingsongLi
Copy link
Contributor Author

CC: @wuchong

@wuchong
Copy link
Member

wuchong commented Oct 30, 2019

Thanks for the fixing @JingsongLi . However, I still not fully understand. Could you explain more about why this fixing works?

JingsongLi
JingsongLi commented Oct 30, 2019
View reviewed changes
...e-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/utils/AggregateUtil.scala
@@ -747,7 +747,7 @@ object AggregateUtil extends Enumeration {
private[flink] def isTableAggregate(aggCalls: util.List[AggregateCall]): Boolean = {
aggCalls
.filter(e => e.getAggregation.isInstanceOf[AggSqlFunction])
.map(e => e.getAggregation.asInstanceOf[AggSqlFunction].makeFunction(null, null))
.map(e => e.getAggregation.asInstanceOf[AggSqlFunction].aggregateFunction)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wuchong , the fix just have this line.
The hive function should been make by correct constants and argTypes. Otherwise it will throw an exception. (See HiveAggSqlFunction)
In this isTableAggregate, it just want to check the agg class type, so the better way is get the function instead of make a function.

Copy link
Member

@wuchong wuchong Oct 30, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But from the exception stack attached in the JIRA, it seems that this is not where the exception throws.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is very old JIRA... At that time, it is a different root cause, but for now, it is a new root cause.
After add it case to hive, we can ensure the right logic.
I think I can update JIRA to new root cause. What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will be great to update the exception.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I got the reason. Could you add a javadoc for makeFunction that it is only used for Hive UDF support, this is a temporary solusion and should be removed once FLIP-65 is finished.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

wuchong
wuchong approved these changes Oct 30, 2019
View reviewed changes
Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wuchong wuchong merged commit 1da3055 into apache:master Oct 30, 2019
@JingsongLi JingsongLi deleted the hiveUdfStream branch October 31, 2019 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuchong wuchong

Assignees
No one assigned
Labels
component=Connectors/Hive component=TableSQL/Planner review=description?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JingsongLi @flinkbot @wuchong @rmetzger