Skip to content

[Discussion] @Reference和@Service Naming issues #6007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mercyblitz opened this issue Apr 13, 2020 · 4 comments · Fixed by #6074
Closed

[Discussion] @Reference和@Service Naming issues #6007

mercyblitz opened this issue Apr 13, 2020 · 4 comments · Fixed by #6074
Assignees
@mercyblitz
Labels
type/proposal Everything you want Dubbo have
Milestone
2.7.7

Comments

@mercyblitz
Copy link
Contributor

The source: apache/dubbo-spring-boot-project#447
The reporter: @linux-china

-- Original Content --

看readme中的demo

@Service(version = "1.0.0")
public class DefaultDemoService implements DemoService {

这个@service 和Spring中的@repository和@service太容易混淆啦。 个人是建议调整为 @DubboService 和 @DubboReference

org.apache.dubbo.config.annotation.Service
org.apache.dubbo.config.annotation.Reference

Spring Boot和其他的RPC框架整合的Demo中，如grpc为 @GRpcService， RSocket RPC为 @RSocketService等
@mercyblitz mercyblitz added the type/proposal Everything you want Dubbo have label Apr 13, 2020
@mercyblitz mercyblitz added this to the 2.7.7 milestone Apr 13, 2020
@mercyblitz mercyblitz mentioned this issue Apr 13, 2020
Closed
@laddcn
Copy link
Contributor

laddcn commented Apr 13, 2020

支持这种改法，注解 @service 在使用过程中确实容易搞错，可以增加新的注解 @DubboService，不会产生歧义，@service 仅作为老版本兼容使用

@DIscord010
Copy link
Contributor

+1

2 similar comments
@mostcool
Copy link

+1

@vergilyn
Copy link

+1

@hengyunabc hengyunabc modified the milestones: 2.7.7, 2.7.8 Apr 27, 2020
@mercyblitz mercyblitz modified the milestones: 2.7.8, 2.7.7 Apr 28, 2020
@mercyblitz mercyblitz self-assigned this Apr 28, 2020
mercyblitz added a commit to mercyblitz/dubbo that referenced this issue Apr 28, 2020
@mercyblitz
Polish apache#6007 : [Discussion] @reference和@service Naming issues

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
89599c5
mercyblitz added a commit to mercyblitz/dubbo that referenced this issue Apr 28, 2020
@mercyblitz
Polish apache#6007 : [Discussion] @reference和@service Naming issues
493ea4b
@mercyblitz mercyblitz linked a pull request Apr 28, 2020 that will close this issue
@Reference和@Service Naming issues #6074
Merged
mercyblitz added a commit to mercyblitz/dubbo that referenced this issue Apr 28, 2020
@mercyblitz
Polish apache#6007 : [Discussion] @reference和@service Naming issues
0e314c8
mercyblitz added a commit that referenced this issue Apr 28, 2020
@mercyblitz
@reference和@service Naming issues (#6074)
78aeadc 
* Polish #6007 : [Discussion] @reference和@service Naming issues

* Polish #6007 : [Discussion] @reference和@service Naming issues

* Polish #6007 : [Discussion] @reference和@service Naming issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mercyblitz mercyblitz

Labels
type/proposal Everything you want Dubbo have
Projects
None yet
Milestone
2.7.7
Development

Successfully merging a pull request may close this issue.

@Reference和@Service Naming issues mercyblitz/dubbo
6 participants
@mercyblitz @hengyunabc @mostcool @vergilyn @DIscord010 @laddcn