Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] @Reference和@Service Naming issues #6007

Closed
mercyblitz opened this issue Apr 13, 2020 · 4 comments · Fixed by #6074
Closed

[Discussion] @Reference和@Service Naming issues #6007

mercyblitz opened this issue Apr 13, 2020 · 4 comments · Fixed by #6074
Assignees
Labels
type/proposal Everything you want Dubbo have
Milestone

Comments

@mercyblitz
Copy link
Contributor

The source: apache/dubbo-spring-boot-project#447
The reporter: @linux-china

-- Original Content --

看readme中的demo

@Service(version = "1.0.0")
public class DefaultDemoService implements DemoService {

这个@service 和Spring中的@repository@service太容易混淆啦。 个人是建议调整为 @DubboService 和 @DubboReference

org.apache.dubbo.config.annotation.Service
org.apache.dubbo.config.annotation.Reference

Spring Boot和其他的RPC框架整合的Demo中,如grpc为 @GRpcService, RSocket RPC为 @RSocketService等

@laddcn
Copy link
Contributor

laddcn commented Apr 13, 2020

支持这种改法,注解 @service 在使用过程中确实容易搞错,可以增加新的注解 @DubboService,不会产生歧义,@service 仅作为老版本兼容使用

@DIscord010
Copy link
Contributor

+1

2 similar comments
@mostcool
Copy link

+1

@vergilyn
Copy link

+1

@hengyunabc hengyunabc modified the milestones: 2.7.7, 2.7.8 Apr 27, 2020
@mercyblitz mercyblitz modified the milestones: 2.7.8, 2.7.7 Apr 28, 2020
@mercyblitz mercyblitz self-assigned this Apr 28, 2020
mercyblitz added a commit to mercyblitz/dubbo that referenced this issue Apr 28, 2020
mercyblitz added a commit to mercyblitz/dubbo that referenced this issue Apr 28, 2020
@mercyblitz mercyblitz linked a pull request Apr 28, 2020 that will close this issue
mercyblitz added a commit to mercyblitz/dubbo that referenced this issue Apr 28, 2020
mercyblitz added a commit that referenced this issue Apr 28, 2020
* Polish #6007 : [Discussion] @reference@service Naming issues

* Polish #6007 : [Discussion] @reference@service Naming issues

* Polish #6007 : [Discussion] @reference@service Naming issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/proposal Everything you want Dubbo have
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants