Skip to content

[improvement] splits large collections to normal collection to avoid the "Requested array size exceeds VM limit" exception #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

lexluo09
Copy link
Contributor

Proposed changes

Splits large collections to normal collection to avoid the "Requested array size exceeds VM limit" exception

  1. Avoid the "Requested array size exceeds VM limit "write exception when a batch is large.
  2. When the batch data is unbalanced, the same batch takes up more storage, and some take up less storage. We can also increase the batch size to avoid exceptions and reduce the write compaction pressure.

Problem Summary:

Recursively splits large collections to normal collection and serializes the collection

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

The exception :
java.lang.OutOfMemoryError: Requested array size exceeds VM limit

…the "Requested array size exceeds VM limit" exception
Copy link
Contributor

@hf200012 hf200012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hf200012 hf200012 merged commit 739725c into apache:master Dec 20, 2022
@lexluo09 lexluo09 deleted the split_big_batch branch December 20, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants