Bookie Client add quarantine ratio when error count exceed threshold #2327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the bookie server in the same time
|
/pulsarbot run-failure-checks |
|
rerun failure checks |
|
Hi @hangc0276 @karanmehta93 @reddycharan @jvrao @merlimat @ravisharda @diegosalvi @sijie maybe interested in this patch |
|
@hangc0276 can please add tests ? |
Yes, I run this patch in my production. With this patch, the standard deviation of the bookies' input throughput decrease from 75MB to 40MB. |
OK, I will add the test case. |
sijie
approved these changes
May 30, 2020
|
@hangc0276 Nice contribution! |
jiazhai
approved these changes
Jun 8, 2020
sijie
pushed a commit
that referenced
this pull request
Aug 13, 2020
### Motivation When bookie client read/write data from/to bookie servers, it will check the health of each connected server in sepecific interval. Once the amount of errors reached the threshold, the bookie server will be quarantined for server miniutes (configurated by `bookieQuarantineTimeSeconds`) by the bookie client. In most circumstance, there are large amount of bookie clients connected to one bookie server, like pulsar broker. Once the bookie server runs in heavy load, most of bookie clients will receive errors and trigger quarantine in the same time, and then quarantine the server for several miniutes. After a few miniutes passed by, the quarantined server will be put back in the same time for most bookie clients, which will lead to periodic oscillation of in/out throughput of the server. It is the obstacle of tunning the throughput of the bookkeeper cluster. ### Changes I introduce a quarantine probability to determine whether to quarantine the server for the client, avoiding quaraninte the heavy load server in the same time for most of bookie client. I also expose the quarantine stats to prometheus. Reviewers: Jia Zhai <zhaijia@apache.org>, Sijie Guo <None> This closes #2327 from hangc0276/bookieClient_Quarantine_ratio (cherry picked from commit 7645cb8) Signed-off-by: Sijie Guo <sijie@apache.org>
Ghatage
pushed a commit
to Ghatage/bookkeeper
that referenced
this pull request
Oct 6, 2020
### Motivation When bookie client read/write data from/to bookie servers, it will check the health of each connected server in sepecific interval. Once the amount of errors reached the threshold, the bookie server will be quarantined for server miniutes (configurated by `bookieQuarantineTimeSeconds`) by the bookie client. In most circumstance, there are large amount of bookie clients connected to one bookie server, like pulsar broker. Once the bookie server runs in heavy load, most of bookie clients will receive errors and trigger quarantine in the same time, and then quarantine the server for several miniutes. After a few miniutes passed by, the quarantined server will be put back in the same time for most bookie clients, which will lead to periodic oscillation of in/out throughput of the server. It is the obstacle of tunning the throughput of the bookkeeper cluster. ### Changes I introduce a quarantine probability to determine whether to quarantine the server for the client, avoiding quaraninte the heavy load server in the same time for most of bookie client. I also expose the quarantine stats to prometheus. Reviewers: Jia Zhai <zhaijia@apache.org>, Sijie Guo <None> This closes apache#2327 from hangc0276/bookieClient_Quarantine_ratio
sijie
pushed a commit
to apache/pulsar
that referenced
this pull request
Nov 13, 2020
…11.1 (#8546) ### Motivation After bookie client upgraded to 4.11.1, it support configure bookie client quarantine ratio. This feature introduced by apache/bookkeeper#2327. ### Changes Add `bookkeeperClientQuarantineRatio` configuration for broker.conf
flowchartsman
pushed a commit
to flowchartsman/pulsar
that referenced
this pull request
Nov 17, 2020
…11.1 (apache#8546) ### Motivation After bookie client upgraded to 4.11.1, it support configure bookie client quarantine ratio. This feature introduced by apache/bookkeeper#2327. ### Changes Add `bookkeeperClientQuarantineRatio` configuration for broker.conf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When bookie client read/write data from/to bookie servers, it will check the health of each connected server in sepecific interval. Once the amount of errors reached the threshold, the bookie server will be quarantined for server miniutes (configurated by
bookieQuarantineTimeSeconds) by the bookie client.In most circumstance, there are large amount of bookie clients connected to one bookie server, like pulsar broker. Once the bookie server runs in heavy load, most of bookie clients will receive errors and trigger quarantine in the same time, and then quarantine the server for several miniutes. After a few miniutes passed by, the quarantined server will be put back in the same time for most bookie clients, which will lead to periodic oscillation of in/out throughput of the server. It is the obstacle of tunning the throughput of the bookkeeper cluster.
Changes
I introduce a quarantine probability to determine whether to quarantine the server for the client, avoiding quaraninte the heavy load server in the same time for most of bookie client.
I also expose the quarantine stats to prometheus.