could not install apisix-ingress if ingress-controller.enabled changed to true when helm install apisix charts #284
+5
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apisix chart and apisix-dashboard chart use {{ .Release.Namespace }}, when we change the config
ingress-controller.enabled
default behaviour, we could not install the apisix-ingress chart.In apisix charts values.yaml
changed to
I want to install apisix and apisix-ingress at the same time. but apisix-ingress could not install successfully. In apisix chart, we do not specify the namesapce, we use {{ .Release.Namespace }}, but in apisix-ingress charts, we use the configured namespace in values.yaml
the code in apisix-ingress-controller charts deployment.yaml, we use a different namespace configured in values.yaml,
the init container could not success, so the apisix ingress controller could not startup
we should use
.Release.Namespace
consistent with others charts, apisix charts and apisix-dashboard.