fix(core): log error instead of warning for unknown properties and elements #36399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
force-pushed
the
unknown-error-logs-2
branch
from
0c053c0
to
2e7ee84
Compare
crisbeto
added
area: core
|
Per comment on previous PR, #35798 (comment), this will need a g3 patch when merged (cl/298655911). |
crisbeto
force-pushed
the
unknown-error-logs-2
branch
from
2e7ee84
to
da05ad3
Compare
crisbeto
force-pushed
the
unknown-error-logs-2
branch
from
da05ad3
to
7b685ab
Compare
…ements Changes the Ivy unknown element/property messages from being logged with `console.warn` to `console.error`. This should make them a bit more visible without breaking existing apps. Furthermore, a lot of folks filter out warning messages in the dev tools' console, whereas errors are usually still shown. BREAKING CHANGE: Warnings about unknown elements are now logged as errors. This won't break your app, but it may trip up tools that expect nothing to be logged via `console.error`. Fixes angular#35699.
crisbeto
force-pushed
the
unknown-error-logs-2
branch
from
7b685ab
to
3734e9b
Compare
IgorMinar
reviewed
Apr 28, 2020
kara
approved these changes
May 1, 2020
kara
added
action: presubmit
kara
added
action: merge
|
Caretaker note: Merging this into G3 requires a patch because there is a test that checks exactly which console method we call (see here) |
3 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
…ements (angular#36399) Changes the Ivy unknown element/property messages from being logged with `console.warn` to `console.error`. This should make them a bit more visible without breaking existing apps. Furthermore, a lot of folks filter out warning messages in the dev tools' console, whereas errors are usually still shown. BREAKING CHANGE: Warnings about unknown elements are now logged as errors. This won't break your app, but it may trip up tools that expect nothing to be logged via `console.error`. Fixes angular#35699. PR Close angular#36399
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is a resubmit of #35798 intended for v10.
Changes the Ivy unknown element/property messages from being logged with
console.warntoconsole.error. This should make them a bit more visible without breaking existing apps. Furthermore, a lot of folks filter out warning messages in the dev tools' console, whereas errors are usually still shown.BREAKING CHANGE:
Warnings about unknown elements are now logged as errors. This won't break your app, but it may trip up tools that expect nothing to be logged via
console.error.Fixes #35699.