fix(core): migration error if program contains files outside of the project #39790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
commented
Nov 20, 2020
| @@ -13,9 +13,7 @@ import {UpdateRecorder} from './update_recorder'; | |||
| export class InitialNavigationTransform { | |||
| private printer = ts.createPrinter(); | |||
|
|
|||
There was a problem hiding this comment.
The changes in this file aren't required for the fix, they just remove unused code.
crisbeto
added
action: review
…roject Currently all of our migrations are set up to find the tsconfig paths within a project, create a `Program` out of each and migrate the files inside of the `Program`. The problem is that the `Program` can include files outside of the project and the CLI APIs that we use to interact with the file system assume that all files are within the project. These changes consolidate the logic, that determines whether a file can be migrated, in a single place and add an extra check to exclude files outside of the root. Fixes angular#39778.
crisbeto
force-pushed
the
39778/migrations-outside-file-error
branch
from
af761e8
to
001d49a
Compare
atscott
approved these changes
Nov 20, 2020
atscott
added
action: merge
AndrewKushnir
pushed a commit
that referenced
this pull request
Nov 20, 2020
…roject (#39790) Currently all of our migrations are set up to find the tsconfig paths within a project, create a `Program` out of each and migrate the files inside of the `Program`. The problem is that the `Program` can include files outside of the project and the CLI APIs that we use to interact with the file system assume that all files are within the project. These changes consolidate the logic, that determines whether a file can be migrated, in a single place and add an extra check to exclude files outside of the root. Fixes #39778. PR Close #39790
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all of our migrations are set up to find the tsconfig paths within a project, create a
Programout of each and migrate the files inside of theProgram. The problem is that theProgramcan include files outside of the project and the CLI APIs that we use to interact with the file system assume that all files are within the project.These changes consolidate the logic, that determines whether a file can be migrated, in a single place and add an extra check to exclude files outside of the root.
Fixes #39778.
Note: I wasn't able to reproduce this in a test, because it has to run in an actual CLI project.