fix(service-worker): correctly handle failed cache-busted request #39786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
added
type: bug/fix
regression
|
You can preview d834d24 at https://pr39786-d834d24.ngbuilds.io/. |
sonukapoor
reviewed
Nov 21, 2020
| if (networkResult.ok) { | ||
| let response = await this.safeFetch(req); | ||
|
|
||
| // Decide whether a cache-busted request is necessary. A cache-busted request is necessary iff |
There was a problem hiding this comment.
Suggested change
| // Decide whether a cache-busted request is necessary. A cache-busted request is necessary iff | |
| // Decide whether a cache-busted request is necessary. A cache-busted request is necessary if |
There was a problem hiding this comment.
Well, this was intended, but I'll change it since it might confuse some people 😅
Thx for taking a look ✨
gkalpak
force-pushed
the
fix-sw-failing-network-requests
branch
from
d834d24
to
31f8591
Compare
|
You can preview 31f8591 at https://pr39786-31f8591.ngbuilds.io/. |
Since 5be4edf, a failing cache-busted network request (such as requests for fetching uncached assets) will cause the ServiceWorker to incorrectly enter a degraded `EXISTING_CLIENTS_ONLY` mode. A failing network request could be caused by many reasons, including the client or server being offline, and does not necessarily signify a broken ServiceWorker state. This commit fixes the logic in `cacheBustedFetchFromNetwork()` to correctly handle errors in network requests. For more details on the problem and the implemented fix see angular#39775. Fixes angular#39775
gkalpak
force-pushed
the
fix-sw-failing-network-requests
branch
from
31f8591
to
febee11
Compare
|
You can preview febee11 at https://pr39786-febee11.ngbuilds.io/. |
sonukapoor
approved these changes
Nov 23, 2020
AndrewKushnir
pushed a commit
that referenced
this pull request
Nov 23, 2020
…9786) Since 5be4edf, a failing cache-busted network request (such as requests for fetching uncached assets) will cause the ServiceWorker to incorrectly enter a degraded `EXISTING_CLIENTS_ONLY` mode. A failing network request could be caused by many reasons, including the client or server being offline, and does not necessarily signify a broken ServiceWorker state. This commit fixes the logic in `cacheBustedFetchFromNetwork()` to correctly handle errors in network requests. For more details on the problem and the implemented fix see #39775. Fixes #39775 PR Close #39786
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 5be4edf, a failing cache-busted network request (such as requests for fetching an uncached asset) will cause the ServiceWorker to incorrectly enter a degraded
EXISTING_CLIENTS_ONLYmode. A failing network request could be caused by many reasons, including the client or server being offline, and does not necessarily signify a broken ServiceWorker state.This commit fixes the logic in
cacheBustedFetchFromNetwork()to correctly handle errors in network requests.For more details on the problem and the implemented fix see #39775.
Fixes #39775.