fix(router): correctly handle string command in outlets #39728
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are many places where examples use just a string for the command in outlets. When using nested outlets, we do not correctly handle this case, as the types and algorithm always expect an array. This PR updates the `createUrlTree` algorithm to account for the possibility of a string literal as the command for an outlet. Fixes angular#18928
atscott
added
action: review
mhevery
approved these changes
Nov 19, 2020
atscott
added
action: merge
AndrewKushnir
pushed a commit
that referenced
this pull request
Nov 20, 2020
There are many places where examples use just a string for the command in outlets. When using nested outlets, we do not correctly handle this case, as the types and algorithm always expect an array. This PR updates the `createUrlTree` algorithm to account for the possibility of a string literal as the command for an outlet. Fixes #18928 PR Close #39728
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many places where examples use just a string for the command
in outlets. When using nested outlets, we do not correctly handle
this case, as the types and algorithm always expect an array.
This PR updates the
createUrlTreealgorithm to account for thepossibility of a string literal as the command for an outlet.
Fixes #18928