Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(compiler-cli): reduce filesystem hits during resource resolution #39604

Closed
wants to merge 3 commits into from
Closed

perf(compiler-cli): reduce filesystem hits during resource resolution #39604

wants to merge 3 commits into from

Conversation

JoostK
Copy link
Member

@JoostK JoostK commented Nov 8, 2020

See individual commits.

@JoostK JoostK added refactoring Issue that involves refactoring or code-cleanup target: patch This PR is targeted for the next patch release engine: ivy area: compiler Issues related to `ngc`, Angular's template compiler labels Nov 8, 2020
@google-cla google-cla bot added the cla: yes label Nov 8, 2020
@ngbot ngbot bot added this to the needsTriage milestone Nov 8, 2020
@JoostK
refactor(compiler-cli): define type alias for the required delegation…
0e45491 
… pattern

The type alias allows for this pattern to be more easily used in other
areas of the compiler code. The current usages of this pattern have been
updated to use the type alias.
@JoostK
perf(compiler-cli): reduce filesystem hits during resource resolution
f1790be 
The resource loader uses TypeScript's module resolution system to
determine at which locations it needs to look for a resource file. A
marker string is used to force the module resolution to fail, such that
all failed lookup locations can then be considered for actual resource
resolution. Any filesystem requests targeting files/directories that
contain the marker are known not to exist, so no filesystem request
needs to be done at all.
@JoostK
fixup! perf(compiler-cli): reduce filesystem hits during resource res…
24e3b63 
…olution
@JoostK JoostK marked this pull request as ready for review November 10, 2020 13:50
@JoostK JoostK added action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit labels Nov 10, 2020
@AndrewKushnir
Copy link
Contributor

Presubmit.

@AndrewKushnir AndrewKushnir removed the action: presubmit The PR is in need of a google3 presubmit label Nov 11, 2020
@atscott atscott closed this in 7c161e1 Nov 12, 2020
atscott pushed a commit that referenced this pull request Nov 12, 2020
@JoostK @atscott
perf(compiler-cli): reduce filesystem hits during resource resolution (…
ade6da9 
…#39604)

The resource loader uses TypeScript's module resolution system to
determine at which locations it needs to look for a resource file. A
marker string is used to force the module resolution to fail, such that
all failed lookup locations can then be considered for actual resource
resolution. Any filesystem requests targeting files/directories that
contain the marker are known not to exist, so no filesystem request
needs to be done at all.

PR Close #39604
atscott pushed a commit that referenced this pull request Nov 12, 2020
@JoostK @atscott
refactor(compiler-cli): define type alias for the required delegation…
7ab31c9 
… pattern (#39604)

The type alias allows for this pattern to be more easily used in other
areas of the compiler code. The current usages of this pattern have been
updated to use the type alias.

PR Close #39604
atscott pushed a commit that referenced this pull request Nov 12, 2020
@JoostK @atscott
perf(compiler-cli): reduce filesystem hits during resource resolution (…
a7adcbd 
…#39604)

The resource loader uses TypeScript's module resolution system to
determine at which locations it needs to look for a resource file. A
marker string is used to force the module resolution to fail, such that
all failed lookup locations can then be considered for actual resource
resolution. Any filesystem requests targeting files/directories that
contain the marker are known not to exist, so no filesystem request
needs to be done at all.

PR Close #39604
basherr pushed a commit to basherr/angular that referenced this pull request Nov 14, 2020
@JoostK @basherr
refactor(compiler-cli): define type alias for the required delegation…
21287b7 
… pattern (angular#39604)

The type alias allows for this pattern to be more easily used in other
areas of the compiler code. The current usages of this pattern have been
updated to use the type alias.

PR Close angular#39604
basherr pushed a commit to basherr/angular that referenced this pull request Nov 14, 2020
@JoostK @basherr
perf(compiler-cli): reduce filesystem hits during resource resolution (…
d827298 
…angular#39604)

The resource loader uses TypeScript's module resolution system to
determine at which locations it needs to look for a resource file. A
marker string is used to force the module resolution to fail, such that
all failed lookup locations can then be considered for actual resource
resolution. Any filesystem requests targeting files/directories that
contain the marker are known not to exist, so no filesystem request
needs to be done at all.

PR Close angular#39604
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler cla: yes refactoring Issue that involves refactoring or code-cleanup target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JoostK @AndrewKushnir @petebacondarwin