fix(core): handle !important in style property value #39603
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
force-pushed
the
35323/style-important
branch
4 times, most recently
from
66543f6
to
16c63a5
Compare
crisbeto
added
action: review
There was a problem hiding this comment.
Looks good, thanks for the fix @crisbeto 👍 Just left a couple comments.
* Fixes that the Ivy styling logic wasn't accounting for `!important` in the property value. * Fixes that the default DOM renderer only sets `!important` on a property with a dash in its name. * Accounts for the `flags` parameter of `setStyle` in the server renderer. Fixes angular#35323.
crisbeto
force-pushed
the
35323/style-important
branch
2 times, most recently
from
08ca3a5
to
84a96f7
Compare
AndrewKushnir
approved these changes
Nov 10, 2020
crisbeto
force-pushed
the
35323/style-important
branch
from
84a96f7
to
5e3b918
Compare
crisbeto
added
action: merge
alxhub
approved these changes
Nov 10, 2020
pullapprove
bot
requested review from
AndrewKushnir,
atscott,
IgorMinar and
jelbourn
AndrewKushnir
approved these changes
Nov 10, 2020
| @@ -12,7 +12,7 @@ | |||
| "master": { | |||
| "uncompressed": { | |||
| "runtime-es2015": 3037, | |||
| "main-es2015": 448922, | |||
| "main-es2015": 449483, | |||
There was a problem hiding this comment.
From the most recent CI run in master:
SUCCESS: Commit 5205db5564f21c214a96000e018a08f3de7d44d8 uncompressed main-es2015 did NOT cross size threshold of 500 bytes or >1% (expected: 448922, actual: 449338).
The current size is 449338 and the size in the PR is 449483, so it's only 145 chars difference which looks reasonable.
|
FYI presubmit is successful for the changes in this PR. |
AndrewKushnir
removed
the
action: presubmit
jelbourn
approved these changes
Nov 12, 2020
basherr
pushed a commit
to basherr/angular
that referenced
this pull request
Nov 14, 2020
* Fixes that the Ivy styling logic wasn't accounting for `!important` in the property value. * Fixes that the default DOM renderer only sets `!important` on a property with a dash in its name. * Accounts for the `flags` parameter of `setStyle` in the server renderer. Fixes angular#35323. PR Close angular#39603
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
pullapprove
bot
added
area: build & ci
|
Also fixes #12009 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!importantin the property value.!importanton a property with a dash in its name.flagsparameter ofsetStylein the server renderer.Fixes #35323.