Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): remove deprecated wtf from ng_zone #37864

Closed
wants to merge 1 commit into from
Closed

fix(core): remove deprecated wtf from ng_zone #37864

wants to merge 1 commit into from

Conversation

JiaLiPassion
Copy link
Contributor

Since WTF is deprecated and removed in v9 in this PR #33949, so
in this PR, WtfZoneSpec is also removed from NgZone.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: 33949

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from mhevery June 30, 2020 22:25
@JiaLiPassion JiaLiPassion added area: zones target: patch This PR is targeted for the next patch release labels Jul 1, 2020
@ngbot ngbot bot added this to the needsTriage milestone Jul 1, 2020
@JiaLiPassion
fix(core): remove deprecated wtfZoneSpec from NgZone
a873a46 
Since `WTF` is deprecated and removed in v9 in this PR angular#33949, so
in this PR, `WtfZoneSpec` is also removed from `NgZone`.
@mhevery
Copy link
Contributor

mhevery commented Jul 15, 2020

presubmit

@pullapprove pullapprove bot removed the request for review from IgorMinar July 23, 2020 03:33
@mhevery
Copy link
Contributor

mhevery commented Jul 27, 2020

presubmit

@mhevery
Copy link
Contributor

mhevery commented Jul 29, 2020

presubmit

@mhevery mhevery self-assigned this Oct 19, 2020
@mhevery
Copy link
Contributor

mhevery commented Oct 19, 2020

presubmit

@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Nov 12, 2020
atscott pushed a commit that referenced this pull request Nov 12, 2020
@JiaLiPassion @atscott
fix(core): remove deprecated wtfZoneSpec from NgZone (#37864)
e02bea8 
Since `WTF` is deprecated and removed in v9 in this PR #33949, so
in this PR, `WtfZoneSpec` is also removed from `NgZone`.

PR Close #37864
@atscott atscott closed this in 8e17dc0 Nov 12, 2020
basherr pushed a commit to basherr/angular that referenced this pull request Nov 14, 2020
@JiaLiPassion @basherr
fix(core): remove deprecated wtfZoneSpec from NgZone (angular#37864)
e4934ca 
Since `WTF` is deprecated and removed in v9 in this PR angular#33949, so
in this PR, `WtfZoneSpec` is also removed from `NgZone`.

PR Close angular#37864
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 13, 2020
@pullapprove pullapprove bot added area: core Issues related to the framework runtime and removed area: zones labels Dec 13, 2020
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

Assignees

@mhevery mhevery

Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JiaLiPassion @mhevery @googlebot