Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): adds get method for QueryList #36907

Closed
wants to merge 2 commits into from
Closed

feat(core): adds get method for QueryList #36907

wants to merge 2 commits into from

Conversation

is2ei
Copy link

@is2ei is2ei commented May 4, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #29467

What is the new behavior?

By using get method, the developer can get the element by index

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from mhevery May 4, 2020 02:01
@is2ei is2ei force-pushed the query-list-get branch 5 times, most recently from 344cd9a to 790c1fa Compare May 4, 2020 04:13
@pullapprove pullapprove bot requested a review from IgorMinar May 4, 2020 04:13
@mhevery mhevery added the area: core Issues related to the framework runtime label May 11, 2020
@ngbot ngbot bot added this to the needsTriage milestone May 11, 2020
IgorMinar
IgorMinar previously requested changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM for public-api change

Reviewed-for: public-api

packages/core/src/linker/query_list.ts Outdated Show resolved Hide resolved
@IgorMinar IgorMinar added target: major This PR is targeted for the next major release feature Issue that requests a new feature labels Jun 10, 2020
@pkozlowski-opensource pkozlowski-opensource self-assigned this Jun 12, 2020
pkozlowski-opensource
pkozlowski-opensource approved these changes Jun 12, 2020
View reviewed changes
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api
Reviewed-for: fw-core

@pkozlowski-opensource
Copy link
Member

@is2ei thnx for this PR. We would like to move it forward, so could you please:

Thnx!

Issei Horie and others added 2 commits November 17, 2020 11:09
@mhevery
feat(core): adds get method to QueryList
3355a83 
This commit adds get method to QueryList.
The method returns an item of the internal results by index number.

PR Close angular#29467
@mhevery
fixup! feat(core): adds get method to QueryList
2397046
@google-cla
Copy link

google-cla bot commented Nov 17, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Nov 17, 2020
@mhevery mhevery added cla: yes and removed cla: no labels Nov 17, 2020
@mhevery
Copy link
Contributor

mhevery commented Nov 17, 2020

presubmit

@mhevery mhevery dismissed IgorMinar’s stale review November 17, 2020 19:12

Incorporated the requested change.

@mhevery mhevery self-assigned this Nov 17, 2020
mhevery
mhevery approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@mhevery mhevery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: global-approvers

@mhevery mhevery added target: patch This PR is targeted for the next patch release target: major This PR is targeted for the next major release and removed target: major This PR is targeted for the next major release target: patch This PR is targeted for the next patch release labels Nov 19, 2020
@IgorMinar IgorMinar added target: minor This PR is targeted for the next minor release and removed target: major This PR is targeted for the next major release labels Nov 19, 2020
@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Nov 19, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 20, 2020
@pullapprove pullapprove bot removed the area: core Issues related to the framework runtime label Dec 20, 2020
@ngbot ngbot bot removed this from the needsTriage milestone Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

@IgorMinar IgorMinar IgorMinar left review comments

Assignees

@mhevery mhevery

@pkozlowski-opensource pkozlowski-opensource

Labels
action: merge The PR is ready for merge by the caretaker cla: yes feature Issue that requests a new feature target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@is2ei @pkozlowski-opensource @mhevery @IgorMinar @googlebot