Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ivy] [style] binding breaking backwards compability changes #35323

Closed
fyllekanin opened this issue Feb 11, 2020 · 3 comments
Closed

[Ivy] [style] binding breaking backwards compability changes #35323

fyllekanin opened this issue Feb 11, 2020 · 3 comments
Assignees
@crisbeto
Labels
area: core Issues related to the framework runtime core: styling bindings freq1: low P2 The issue is important to a large percentage of users, with a workaround regression Indicates than the issue relates to something that worked in a previous version state: has PR type: bug/fix
Milestone
Backlog

Comments

@fyllekanin
Copy link

fyllekanin commented Feb 11, 2020 •
edited

馃悶 bug report

Affected Package

Ivy rendering enginge

Is this a regression?

Stepped from 8.2 to 9.0
We used ViewEngine in 8.2 and got Ivy in 9.0
Worked in ViewEngine

Description

[style] binding have two breaking backwards compability changes regarding handling of SafeStyle and using !important in the inline CSS

馃敩 Minimal Reproduction

https://stackblitz.com/edit/ivy-pmmnek

馃敟 Exception or Error

No exception thrown

馃實 Your Environment

Angular Version:
9.0.0 , package.json detailed in the stackblitz

Anything else relevant?
N/A
@kara kara added area: core Issues related to the framework runtime comp: ivy labels Feb 13, 2020
@ngbot ngbot bot modified the milestone: needsTriage Feb 13, 2020
@pkozlowski-opensource pkozlowski-opensource added severity3: broken regression Indicates than the issue relates to something that worked in a previous version freq1: low type: bug/fix and removed severity3: broken labels Feb 24, 2020
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Feb 24, 2020
@fyllekanin
Copy link
Author

Was a while now, anything new about this?
Stopping me from stepping the Angular version in a few projects and would love the Ivy performance improvement

@fyllekanin
Copy link
Author

Just checking back, I'm not great at looking at PR's , any progress on this?
Don't know how angular is for backwards compability stuff

@jelbourn jelbourn added the P2 The issue is important to a large percentage of users, with a workaround label Oct 1, 2020
crisbeto added a commit to crisbeto/angular that referenced this issue Nov 8, 2020
@crisbeto
fix(core): handle !important in style property value
d35e34e 
* Fixes that the Ivy styling logic wasn't accounting for `!important` in the property value.
* Fixes that the default DOM renderer only set `!important` on a property with a dash in its name.
* Accounts for the `flags` parameter of `setStyle` in the server renderer.

Fixes angular#35323.
@crisbeto crisbeto mentioned this issue Nov 8, 2020
Closed
crisbeto added a commit to crisbeto/angular that referenced this issue Nov 8, 2020
@crisbeto
fix(core): handle !important in style property value
de58cbe 
* Fixes that the Ivy styling logic wasn't accounting for `!important` in the property value.
* Fixes that the default DOM renderer only set `!important` on a property with a dash in its name.
* Accounts for the `flags` parameter of `setStyle` in the server renderer.

Fixes angular#35323.
crisbeto added a commit to crisbeto/angular that referenced this issue Nov 8, 2020
@crisbeto
fix(core): handle !important in style property value
6a29694 
* Fixes that the Ivy styling logic wasn't accounting for `!important` in the property value.
* Fixes that the default DOM renderer only set `!important` on a property with a dash in its name.
* Accounts for the `flags` parameter of `setStyle` in the server renderer.

Fixes angular#35323.
crisbeto added a commit to crisbeto/angular that referenced this issue Nov 8, 2020
@crisbeto
fix(core): handle !important in style property value
66543f6 
* Fixes that the Ivy styling logic wasn't accounting for `!important` in the property value.
* Fixes that the default DOM renderer only set `!important` on a property with a dash in its name.
* Accounts for the `flags` parameter of `setStyle` in the server renderer.

Fixes angular#35323.
crisbeto added a commit to crisbeto/angular that referenced this issue Nov 8, 2020
@crisbeto
fix(core): handle !important in style property value
16c63a5 
* Fixes that the Ivy styling logic wasn't accounting for `!important` in the property value.
* Fixes that the default DOM renderer only sets `!important` on a property with a dash in its name.
* Accounts for the `flags` parameter of `setStyle` in the server renderer.

Fixes angular#35323.
@crisbeto crisbeto self-assigned this Nov 8, 2020
crisbeto added a commit to crisbeto/angular that referenced this issue Nov 10, 2020
@crisbeto
fix(core): handle !important in style property value
2c171f4 
* Fixes that the Ivy styling logic wasn't accounting for `!important` in the property value.
* Fixes that the default DOM renderer only sets `!important` on a property with a dash in its name.
* Accounts for the `flags` parameter of `setStyle` in the server renderer.

Fixes angular#35323.
atscott pushed a commit that referenced this issue Nov 12, 2020
@crisbeto @atscott
fix(core): handle !important in style property value (#39603)
978f081 
* Fixes that the Ivy styling logic wasn't accounting for `!important` in the property value.
* Fixes that the default DOM renderer only sets `!important` on a property with a dash in its name.
* Accounts for the `flags` parameter of `setStyle` in the server renderer.

Fixes #35323.

PR Close #39603
basherr pushed a commit to basherr/angular that referenced this issue Nov 14, 2020
@crisbeto @basherr
fix(core): handle !important in style property value (angular#39603)
8da09c4 
* Fixes that the Ivy styling logic wasn't accounting for `!important` in the property value.
* Fixes that the default DOM renderer only sets `!important` on a property with a dash in its name.
* Accounts for the `flags` parameter of `setStyle` in the server renderer.

Fixes angular#35323.

PR Close angular#39603
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
area: core Issues related to the framework runtime core: styling bindings freq1: low P2 The issue is important to a large percentage of users, with a workaround regression Indicates than the issue relates to something that worked in a previous version state: has PR type: bug/fix
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

fix(core): handle !important in style property value crisbeto/angular
5 participants
@jelbourn @pkozlowski-opensource @kara @crisbeto @fyllekanin