Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): remove deprecated and defunct wtf* apis #33949

Closed
wants to merge 2 commits into from

Conversation

IgorMinar
Copy link
Contributor

@IgorMinar IgorMinar commented Nov 21, 2019

These apis have been deprecated in v8, but since they are defunct we are removing them early so that they don't take up payload size.

Closes #12509

@IgorMinar IgorMinar requested review from a team as code owners November 21, 2019 01:17
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IgorMinar IgorMinar added the target: patch This PR is targeted for the next patch release label Nov 21, 2019
@JiaLiPassion
Copy link
Contributor

@IgorMinar , should we also remove wtfZoneSpec from ngZone here https://github.com/angular/angular/blob/master/packages/core/src/zone/ng_zone.ts#L133?

These apis have been deprecated in v8, so they should stick around till v10,
but since they are defunct we are removing them early so that they don't take up payload size.
@mary-poppins
Copy link

You can preview b6b42b2 at https://pr33949-b6b42b2.ngbuilds.io/.

@IgorMinar
Copy link
Contributor Author

hmm @JiaLiPassion I didn't realize that there was a wtf specific zone spec.

Is anyone using it? this zone spec is separate from exposing the wtf apis so I think it's ok to remove stuff from core, but keep wtf support in zone.js.

@IgorMinar
Copy link
Contributor Author

thanks for pointing this out btw

@IgorMinar
Copy link
Contributor Author

I'm marking this as blocked until we agree on the zone.js spec story

@mary-poppins
Copy link

You can preview 937d528 at https://pr33949-937d528.ngbuilds.io/.

@IgorMinar
Copy link
Contributor Author

looking into this more, I think we should go ahead with this change as is without removing the zone.js integration in ng_zone. That can be done separately in the future.

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed state: blocked labels Nov 21, 2019
@IgorMinar
Copy link
Contributor Author

merge-assistance: global approval

@matsko
Copy link
Contributor

matsko commented Nov 22, 2019

@JiaLiPassion
Copy link
Contributor

@IgorMinar , yeah, sure, there is no harm to leave the wtfZoneSpec in ngZone for now, and I don't think any one are really using it because wtf itself is not continued. Thanks for looking into it.

@matsko matsko closed this in ed55355 Nov 25, 2019
matsko pushed a commit that referenced this pull request Nov 25, 2019
These apis have been deprecated in v8, so they should stick around till v10,
but since they are defunct we are removing them early so that they don't take up payload size.

PR Close #33949
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web Tracing Framework no longer Working in Angular
6 participants