build: TypeScript 3.5 upgrade #31615

IgorMinar · 2019-07-18T00:50:45Z

https://github.com/Microsoft/TypeScript/wiki/Breaking-Changes#typescript-35

mary-poppins · 2019-07-18T00:57:22Z

You can preview a93050d at https://pr31615-a93050d.ngbuilds.io/.

IgorMinar · 2019-07-18T17:43:00Z

//packages/compiler-cli/test/ngtsc:ngtsc is failing due to compiler host not being passed properly somewhere in between our test setup, tsickle, and typescript. My guess is that the test doesn't properly initialize the environment. @alxhub is this something you could look into please? Feel free to push to this branch.

EatonZ · 2019-07-18T18:43:13Z

TypesScript should be TypeScript (no extra s) in the title.😉

googlebot · 2019-07-18T18:48:16Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only "I consent." in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

mary-poppins · 2019-07-18T18:55:44Z

You can preview 4febac9 at https://pr31615-4febac9.ngbuilds.io/.

mary-poppins · 2019-07-18T23:46:33Z

You can preview 86a3fd6 at https://pr31615-86a3fd6.ngbuilds.io/.

mary-poppins · 2019-07-25T16:17:13Z

You can preview abfc719 at https://pr31615-abfc719.ngbuilds.io/.

mary-poppins · 2019-07-25T16:43:53Z

You can preview 951f3ec at https://pr31615-951f3ec.ngbuilds.io/.

mary-poppins · 2019-07-25T17:03:18Z

You can preview b6985fd at https://pr31615-b6985fd.ngbuilds.io/.

IgorMinar · 2019-07-25T21:42:42Z

@EatonZ :-D thanks for pointing that out

mary-poppins · 2019-07-25T21:48:26Z

You can preview 57034a7 at https://pr31615-57034a7.ngbuilds.io/.

mary-poppins · 2019-07-25T22:36:39Z

You can preview d0ceee3 at https://pr31615-d0ceee3.ngbuilds.io/.

googlebot · 2019-07-25T22:52:30Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

mary-poppins · 2019-07-25T22:59:19Z

You can preview 2a07df6 at https://pr31615-2a07df6.ngbuilds.io/.

mary-poppins · 2019-07-25T23:00:22Z

You can preview e390cda at https://pr31615-e390cda.ngbuilds.io/.

https://github.com/Microsoft/TypeScript/wiki/Breaking-Changes#typescript-35

mary-poppins · 2019-07-25T23:08:45Z

You can preview 82b374b at https://pr31615-82b374b.ngbuilds.io/.

mary-poppins · 2019-07-25T23:13:30Z

You can preview e538486 at https://pr31615-e538486.ngbuilds.io/.

mary-poppins · 2019-07-25T23:14:58Z

You can preview 6fff209 at https://pr31615-6fff209.ngbuilds.io/.

IgorMinar

notes on the changes I make to make the review easier.

IgorMinar · 2019-07-25T21:55:13Z

packages/compiler-cli/test/metadata/collector_spec.ts

@@ -60,7 +60,7 @@ describe('Collector', () => {
      version: METADATA_VERSION,
      metadata: {
        DeclaredClass: {__symbolic: 'class'},
-        declaredFn: {__symbolic: 'function'},
+        declaredFn: {__symbolic: 'function'} as any,


this is just a spec and the legacy ngc internal types are off, so any seems like the best way to go

IgorMinar · 2019-07-25T21:56:08Z

packages/core/src/event_emitter.ts

@@ -56,7 +56,7 @@ import {Subject, Subscription} from 'rxjs';
 *
 * @publicApi
 */
-export class EventEmitter<T> extends Subject<T> {
+export class EventEmitter<T extends any> extends Subject<T> {


T otherwise end up defaults to unknown

IgorMinar · 2019-07-25T21:56:37Z

packages/platform-webworker/src/web_workers/shared/post_message_bus.ts

@@ -14,7 +14,7 @@ import {MessageBus, MessageBusSink, MessageBusSource} from './message_bus';

 // TODO(jteplitz602): Replace this with the definition in lib.webworker.d.ts(#3492)
 export interface PostMessageTarget {
-  postMessage: (message: any, transfer?: [ArrayBuffer]) => void;
+  postMessage: (message: any, transfer?: [Transferable]) => void;


this is not a public api so it's ok to change and correct

IgorMinar · 2019-07-25T23:22:08Z

packages/common/testing/src/mock_platform_location.ts

@@ -93,7 +93,8 @@ export interface MockPlatformLocationConfig {
 *
 * @publicApi
 */
-export const MOCK_PLATFORM_LOCATION_CONFIG = new InjectionToken('MOCK_PLATFORM_LOCATION_CONFIG');
+export const MOCK_PLATFORM_LOCATION_CONFIG =
+    new InjectionToken<MockPlatformLocationConfig>('MOCK_PLATFORM_LOCATION_CONFIG');


this makes the type more precise but I don't expect this to break anyone, the alternative is unknown which is likely more breaky.

IgorMinar · 2019-07-25T23:22:49Z

packages/compiler-cli/test/diagnostics/check_types_spec.ts

@@ -771,12 +771,6 @@ describe('ng type checker', () => {
          '<div>{{"hello" | aPipe}}</div>',
          `Argument of type '"hello"' is not assignable to parameter of type 'number'.`, '0:5');
    });
-    it('should report an index into a map expression', () => {


this error is now being caught by typescript, so the test fails because the diagnostic comes from tsc rather than ngc. that's why I removed the test.

IgorMinar · 2019-07-25T23:23:29Z

packages/core/src/linker/element_ref.ts

@@ -24,7 +24,7 @@ import {noop} from '../util/noop';
 // Note: We don't expose things like `Injector`, `ViewContainer`, ... here,
 // i.e. users have to ask for what they need. With that, we can build better analysis tools
 // and could do better codegen in the future.
-export class ElementRef<T = any> {
+export class ElementRef<T extends any = any> {


not ideal, but the goal was to make this backwards compatible now that unspecified generics result in unknown and the default value is not being honored.

Would this not extend Node???

because that would make it much more strict than what we have today and would break even those people that are not upgrading typescript.

we can update this stuff in v9 to a more precise type, but we can't do it in 8.2

mhevery · 2019-07-25T23:33:43Z

packages/core/src/linker/element_ref.ts

@@ -24,7 +24,7 @@ import {noop} from '../util/noop';
 // Note: We don't expose things like `Injector`, `ViewContainer`, ... here,
 // i.e. users have to ask for what they need. With that, we can build better analysis tools
 // and could do better codegen in the future.
-export class ElementRef<T = any> {
+export class ElementRef<T extends any = any> {


Would this not extend Node???

IgorMinar · 2019-07-25T23:55:06Z

merge-assistance: global approval

https://github.com/Microsoft/TypeScript/wiki/Breaking-Changes#typescript-35 PR Close angular#31615

angular-automatic-lock-bot · 2019-09-15T08:51:40Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

IgorMinar requested review from a team as code owners July 18, 2019 00:50

googlebot added the cla: yes label Jul 18, 2019

IgorMinar added the state: WIP label Jul 18, 2019

googlebot added cla: no and removed cla: yes labels Jul 18, 2019

IgorMinar requested a review from a team as a code owner July 18, 2019 23:36

IgorMinar force-pushed the build/ts-3.5-upgrade branch from bd8d99f to 86a3fd6 Compare July 18, 2019 23:38

filipesilva mentioned this pull request Jul 22, 2019

AoT hangs forever after updating from v6 to v7 (or v8) angular/angular-cli#15113

Closed

IgorMinar force-pushed the build/ts-3.5-upgrade branch from 86a3fd6 to abfc719 Compare July 25, 2019 16:06

IgorMinar changed the title ~~build: TypesScript 3.5 upgrade~~ build: TypeScript 3.5 upgrade Jul 25, 2019

IgorMinar force-pushed the build/ts-3.5-upgrade branch from d0ceee3 to 2a07df6 Compare July 25, 2019 22:52

googlebot added cla: yes and removed cla: no labels Jul 25, 2019

IgorMinar force-pushed the build/ts-3.5-upgrade branch from 2a07df6 to e390cda Compare July 25, 2019 22:52

IgorMinar force-pushed the build/ts-3.5-upgrade branch 2 times, most recently from 82b374b to e538486 Compare July 25, 2019 23:07

IgorMinar requested a review from a team as a code owner July 25, 2019 23:07

build: TypeScript 3.5 upgrade

6fff209

https://github.com/Microsoft/TypeScript/wiki/Breaking-Changes#typescript-35

IgorMinar force-pushed the build/ts-3.5-upgrade branch from e538486 to 6fff209 Compare July 25, 2019 23:08

mhevery added the area: core Issues related to the framework runtime label Jul 25, 2019

ngbot bot added this to the needsTriage milestone Jul 25, 2019

IgorMinar commented Jul 25, 2019

View reviewed changes

IgorMinar added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release and removed state: WIP labels Jul 25, 2019

mhevery approved these changes Jul 25, 2019

View reviewed changes

IgorMinar added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jul 25, 2019

mhevery closed this in 6ece7db Jul 26, 2019

alan-agius4 mentioned this pull request Jul 26, 2019

feat: add support for typescript 3.5 and Angular 8.X pre-releases ng-packagr/ng-packagr#1351

Merged

AndrewKushnir mentioned this pull request Jul 31, 2019

TypeScript 3.5 Support #31059

Closed

arturovt mentioned this pull request Jul 31, 2019

build(typescript): upgrade to the v3.5 ngxs/store#1195

Merged

3 tasks

filipesilva mentioned this pull request Aug 15, 2019

Angular 7/8 FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory angular/angular-cli#13734

Closed

sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019

build: TypeScript 3.5 upgrade (angular#31615)

a918320

https://github.com/Microsoft/TypeScript/wiki/Breaking-Changes#typescript-35 PR Close angular#31615

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: TypeScript 3.5 upgrade #31615

build: TypeScript 3.5 upgrade #31615

IgorMinar commented Jul 18, 2019

mary-poppins commented Jul 18, 2019

IgorMinar commented Jul 18, 2019

EatonZ commented Jul 18, 2019

googlebot commented Jul 18, 2019

mary-poppins commented Jul 18, 2019

mary-poppins commented Jul 18, 2019

mary-poppins commented Jul 25, 2019

mary-poppins commented Jul 25, 2019

mary-poppins commented Jul 25, 2019

IgorMinar commented Jul 25, 2019

mary-poppins commented Jul 25, 2019

mary-poppins commented Jul 25, 2019

googlebot commented Jul 25, 2019

mary-poppins commented Jul 25, 2019

mary-poppins commented Jul 25, 2019

mary-poppins commented Jul 25, 2019

mary-poppins commented Jul 25, 2019

mary-poppins commented Jul 25, 2019

IgorMinar left a comment

IgorMinar Jul 25, 2019

IgorMinar Jul 25, 2019

IgorMinar Jul 25, 2019

IgorMinar Jul 25, 2019

IgorMinar Jul 25, 2019

IgorMinar Jul 25, 2019

mhevery Jul 25, 2019

IgorMinar Jul 25, 2019

mhevery Jul 25, 2019

IgorMinar commented Jul 25, 2019

angular-automatic-lock-bot bot commented Sep 15, 2019

build: TypeScript 3.5 upgrade #31615

build: TypeScript 3.5 upgrade #31615

Conversation

IgorMinar commented Jul 18, 2019

mary-poppins commented Jul 18, 2019

IgorMinar commented Jul 18, 2019

EatonZ commented Jul 18, 2019

googlebot commented Jul 18, 2019

mary-poppins commented Jul 18, 2019

mary-poppins commented Jul 18, 2019

mary-poppins commented Jul 25, 2019

mary-poppins commented Jul 25, 2019

mary-poppins commented Jul 25, 2019

IgorMinar commented Jul 25, 2019

mary-poppins commented Jul 25, 2019

mary-poppins commented Jul 25, 2019

googlebot commented Jul 25, 2019

mary-poppins commented Jul 25, 2019

mary-poppins commented Jul 25, 2019

mary-poppins commented Jul 25, 2019

mary-poppins commented Jul 25, 2019

mary-poppins commented Jul 25, 2019

IgorMinar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IgorMinar commented Jul 25, 2019

angular-automatic-lock-bot bot commented Sep 15, 2019