fix(bazel): pass custom bazel compiler host rather than rewriting one #31496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch back to passing a custom bazel host instead of rewriting one that is passed to `compile` now that the Angular indexer is stable. Revert "feat(bazel): allow passing and rewriting an old bazel host" This reverts commit 0a4c1c8.
ayazhafiz
added
area: bazel
kyliau
approved these changes
Jul 10, 2019
sabeersulaiman
pushed a commit
to sabeersulaiman/angular
that referenced
this pull request
Sep 6, 2019
…angular#31496) Switch back to passing a custom bazel host instead of rewriting one that is passed to `compile` now that the Angular indexer is stable. Revert "feat(bazel): allow passing and rewriting an old bazel host" This reverts commit 0a4c1c8. PR Close angular#31496
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch back to passing a custom bazel host instead of rewriting one that
is passed to
compilenow that the Angular indexer is stable.Revert "feat(bazel): allow passing and rewriting an old bazel host"
This reverts commit 0a4c1c8.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Rewrites an old bazel host.
Issue Number: N/A
What is the new behavior?
User has to define their own bazel host
Does this PR introduce a breaking change?
Should only impact the Angular indexer inside Google. This change is has not been documented and announced publicly.