Skip to content

fix(bazel): revert location of xi18n outputs to bazel-genfiles #31410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(bazel): revert location of xi18n outputs to bazel-genfiles #31410

wants to merge 1 commit into from
+11 −2

Conversation

alexeagle
Copy link
Contributor

This is needed in g3 where the translation system is sensitive to the full path of the output.

@alexeagle alexeagle requested a review from gregmagolan July 3, 2019 16:49
@alexeagle alexeagle requested a review from a team as a code owner July 3, 2019 16:49
@alxhub alxhub added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Jul 3, 2019
kara
kara approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexeagle alexeagle requested a review from a team as a code owner July 3, 2019 17:27
gregmagolan
gregmagolan approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexeagle alexeagle requested a review from a team as a code owner July 3, 2019 19:42
@alexeagle
fix(bazel): revert location of xi18n outputs to bazel-genfiles

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 136F30F901A2231D
Learn about vigilant mode
e720377 
This is needed in g3 where the translation system is sensitive to the full path of the output.
For Bazel users, we don't want this because it would force them to
disable a Bazel option that prevents using the deprecated ctx.new_file
API
@alxhub alxhub closed this in 1d3e227 Jul 3, 2019
@alexeagle alexeagle deleted the revert_xi18n branch July 3, 2019 22:24
akanshgulati pushed a commit to akanshgulati/angular that referenced this pull request Jul 5, 2019
@alexeagle @akanshgulati
fix: revert location of xi18n outputs to bazel-genfiles (angular#31410)
b066d4e 
This is needed in g3 where the translation system is sensitive to the full path of the output.
For Bazel users, we don't want this because it would force them to
disable a Bazel option that prevents using the deprecated ctx.new_file
API

PR Close angular#31410
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gregmagolan gregmagolan

@kara kara

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alexeagle @gregmagolan @kara @alxhub @googlebot