feat(bazel): allow passing and rewriting an old bazel host #31381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the decision made in angular#31341; this is for the Angular indexer inside Google. The indexer currently passes (and ngc-wrapped#compile accepts) a bazel host to use, but because many methods are overwritten specially for Angular compilation a better approach is to pass an old bazel compiler host and siphon methods needed off of it before creating a new host. This enables that.
ayazhafiz
added
feature
kyliau
approved these changes
Jul 2, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the decision made in #31341; this is for the Angular indexer
inside Google. The indexer currently passes (and ngc-wrapped#compile
accepts) a bazel host to use, but because many methods are overwritten
specially for Angular compilation a better approach is to pass an old
bazel compiler host and siphon methods needed off of it before creating
a new host. This enables the later approach.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The indexer currently passes (and ngc-wrapped#compile accepts) a bazel host to use.
What is the new behavior?
ngc-wrapped#compileaccepts an old bazel compiler host and siphons methods off of it before creating a new host.Does this PR introduce a breaking change?
This breaks the Angular indexer inside Google. Is it highly unlikely that anyone is using this API. Migration plan is to change the
bazelHostproperty passed tocompiletooldBazelHost.Other information