Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use the correct WTF array to iterate over #31208

Closed
wants to merge 1 commit into from
Closed

fix: use the correct WTF array to iterate over #31208

wants to merge 1 commit into from

Conversation

hmdhk
Copy link

@hmdhk hmdhk commented Jun 22, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@hmdhk hmdhk requested a review from IgorMinar as a code owner June 22, 2019 05:46
@hmdhk hmdhk mentioned this pull request Jun 22, 2019
Closed
JiaLiPassion
JiaLiPassion approved these changes Jun 22, 2019
View reviewed changes
Copy link
Contributor

@JiaLiPassion JiaLiPassion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@JiaLiPassion
Copy link
Contributor

@jahtalab, thank you.
This is a PR pending in zone.js repo, and it is ready for merge.

@ngbot ngbot bot added this to the needsTriage milestone Jun 26, 2019
@sod sod mentioned this pull request Jul 8, 2019
Closed
@gkalpak gkalpak removed the request for review from IgorMinar July 11, 2019 14:57
@gkalpak gkalpak added area: performance action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release type: bug/fix merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jul 11, 2019
@gkalpak
Copy link
Member

gkalpak commented Jul 11, 2019

merge-assistance: Requires g3sync presubmit.

@matsko matsko closed this in 9204de9 Jul 11, 2019
matsko pushed a commit that referenced this pull request Jul 11, 2019
@jahtalab @matsko
fix: use the correct WTF array to iterate over (#31208)
4aed480 
PR Close #31208
@JiaLiPassion JiaLiPassion mentioned this pull request Jul 19, 2019
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JiaLiPassion JiaLiPassion JiaLiPassion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: performance area: zones cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hmdhk @JiaLiPassion @gkalpak @kara @googlebot @jahtalab