V8/static queries patch #30641
Closed
V8/static queries patch #30641
+293
−308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxhub
added
hotlist: release-blocker
action: merge
kara
added
the
merge: caretaker note
|
merge-assistance: global approval |
alxhub
force-pushed
the
v8/static-queries-patch
branch
from
712d158 to
fbf247d
Compare
kara
added
the
action: cleanup
alxhub
force-pushed
the
v8/static-queries-patch
branch
from
fbf247d to
f9fe21c
Compare
alxhub
removed
the
action: cleanup
alxhub
force-pushed
the
v8/static-queries-patch
branch
from
f9fe21c to
db618de
Compare
This commit makes the static flag on @ViewChild and @ContentChild required. BREAKING CHANGE: In Angular version 8, it's required that all @ViewChild and @ContentChild queries have a 'static' flag specifying whether the query is 'static' or 'dynamic'. The compiler previously sorted queries automatically, but in 8.0 developers are required to explicitly specify which behavior is wanted. This is a temporary requirement as part of a migration; see https://angular.io/guide/static-query-migration for more details. @ViewChildren and @ContentChildren queries are always dynamic, and so are unaffected.
alxhub
force-pushed
the
v8/static-queries-patch
branch
from
db618de to
8230ad7
Compare
|
You can preview 712d158 at https://pr30641-712d158.ngbuilds.io/. |
jasonaden
pushed a commit
that referenced
this pull request
May 23, 2019
jasonaden
pushed a commit
that referenced
this pull request
May 23, 2019
jasonaden
pushed a commit
that referenced
this pull request
May 23, 2019
jasonaden
pushed a commit
that referenced
this pull request
May 23, 2019
jasonaden
pushed a commit
that referenced
this pull request
May 23, 2019
This commit makes the static flag on @ViewChild and @ContentChild required. BREAKING CHANGE: In Angular version 8, it's required that all @ViewChild and @ContentChild queries have a 'static' flag specifying whether the query is 'static' or 'dynamic'. The compiler previously sorted queries automatically, but in 8.0 developers are required to explicitly specify which behavior is wanted. This is a temporary requirement as part of a migration; see https://angular.io/guide/static-query-migration for more details. @ViewChildren and @ContentChildren queries are always dynamic, and so are unaffected. PR Close #30641
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch version of #30639, including Kara's cherry-picked fixes.