Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bazel): ng test should run specific ts_web_test_suite #30526

Closed
wants to merge 1 commit into from
Closed

fix(bazel): ng test should run specific ts_web_test_suite #30526

wants to merge 1 commit into from

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented May 16, 2019

PR closes #30191

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau requested a review from a team as a code owner May 16, 2019 22:18
@kyliau kyliau added area: bazel Issues related to the published `@angular/bazel` build rules target: patch This PR is targeted for the next patch release labels May 16, 2019
@ngbot ngbot bot added this to the needsTriage milestone May 16, 2019
@gregmagolan gregmagolan self-requested a review May 16, 2019 23:20
gregmagolan
gregmagolan reviewed May 16, 2019
View reviewed changes
Copy link
Contributor

@gregmagolan gregmagolan left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just add in the commit message why the change is needed and that it assumes that the BUILD files are the ones generated by ng new.

The downside of this is that if you leave BUILD files on disk and add more tests than ng test will no longer run all tests which may be unexpected. Maybe Alex's suggestion to mark rollup_bundle as "manual" would be better?

@mgechev
Copy link
Member

mgechev commented May 19, 2019

This LGTM but I'll let @alexeagle & @gregmagolan give the final approval.

@alexeagle alexeagle added action: merge The PR is ready for merge by the caretaker and removed state: Blocked labels May 20, 2019
@alexeagle
Copy link
Contributor

I agree with @gregmagolan that users may get confused over the behavior when they start to customize the build, but they'll have to understand which targets to run when they do that. This would be a good fix for 8

@alexeagle alexeagle modified the milestones: needsTriage, version 8 May 20, 2019
@jasonaden jasonaden closed this in e688e02 May 20, 2019
jasonaden pushed a commit that referenced this pull request May 20, 2019
@kyliau @jasonaden
fix(bazel): ng test should run specific ts_web_test_suite (#30526)
8bc4da8 
PR closes #30191

PR Close #30526
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
@kyliau @BioPhoton
fix(bazel): ng test should run specific ts_web_test_suite (angular#30526
d24a5a7 
)

PR closes angular#30191

PR Close angular#30526
@iget-master iget-master mentioned this pull request Jul 10, 2019
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
@kyliau kyliau deleted the ngtest branch October 16, 2019 17:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gregmagolan gregmagolan gregmagolan left review comments

@mgechev mgechev mgechev approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
version 8
Development

Successfully merging this pull request may close these issues.

bazel schematic builds prod bundle for ng test
5 participants
@kyliau @mgechev @alexeagle @gregmagolan @googlebot