Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): remove deprecated annotation for TestBed.get #30514

Closed
wants to merge 1 commit into from
Closed

fix(core): remove deprecated annotation for TestBed.get #30514

wants to merge 1 commit into from

Conversation

cexbrayat
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #29905 and FW-1336

What is the new behavior?

PR #29290 introduced a new TestBed.get signature and deprecated the existing one.
This raises a lot of TSLint deprecation warnings in projects using a strict TS config (see #29905 for context), so we are temporarily removing the @deprecated annotation in favor of a plain text warning until we properly fix it.

Does this PR introduce a breaking change?

  • Yes
  • No

@cexbrayat cexbrayat requested a review from a team as a code owner May 16, 2019 15:41
@cexbrayat cexbrayat requested a review from a team as a code owner May 16, 2019 15:45
@cexbrayat cexbrayat mentioned this pull request May 16, 2019
Closed
@jasonaden jasonaden added the area: core Issues related to the framework runtime label May 16, 2019
@ngbot ngbot bot added this to the needsTriage milestone May 16, 2019
kara
kara requested changes May 17, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit

packages/core/testing/src/test_bed.ts Show resolved Hide resolved
@kara kara added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release labels May 17, 2019
@cexbrayat cexbrayat removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 17, 2019
@cexbrayat cexbrayat requested a review from kara May 17, 2019 18:55
@cexbrayat cexbrayat removed their assignment May 17, 2019
kara
kara approved these changes May 17, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though we should still get a public API review from @IgorMinar

@kara kara added action: review The PR is still awaiting reviews from at least one requested reviewer risk: medium labels May 17, 2019
IgorMinar
IgorMinar approved these changes May 18, 2019
View reviewed changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also suggest that you rename the commit message to "fix(core): temporarily remove @deprecated jsdoc tag for a TextBed.get overload"

packages/core/testing/src/test_bed.ts Show resolved Hide resolved
@IgorMinar IgorMinar added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 18, 2019
@IgorMinar IgorMinar modified the milestones: needsTriage, version 8 May 18, 2019
@cexbrayat
fix(core): temporarily remove @deprecated jsdoc tag for a TextBed.get…
7f50ab1 
… overload

PR angular#29290 introduced a new `TestBed.get` signature and deprecated the existing one.
This raises a lot of TSLint deprecation warnings in projects using a strict TS config (see angular#29905 for context), so we are temporarily removing the `@deprecated` annotation in favor of a plain text warning until we properly fix it.

Refs angular#29905
Fixes FW-1336
@cexbrayat cexbrayat requested a review from IgorMinar May 18, 2019 08:58
@cexbrayat cexbrayat removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 18, 2019
@cexbrayat
Copy link
Member Author

@IgorMinar I updated the doc to mention the TSLint issue according to your feedback and changed the commit message.

@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label May 20, 2019
@IgorMinar IgorMinar added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label May 20, 2019
@ngbot
Copy link

ngbot bot commented May 20, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci-codefresh-bazel" is failing
    failure status "ci/angular: size" is failing
    pending status "codefresh-angular" is pending
    pending status "google3" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@IgorMinar
Copy link
Contributor

merge-assistance: ci is flaky

@jasonaden jasonaden closed this in f6bf892 May 21, 2019
jasonaden pushed a commit that referenced this pull request May 21, 2019
@cexbrayat @jasonaden
fix(core): temporarily remove @deprecated jsdoc tag for a TextBed.get…
561e01d 
… overload (#30514)

PR #29290 introduced a new `TestBed.get` signature and deprecated the existing one.
This raises a lot of TSLint deprecation warnings in projects using a strict TS config (see #29905 for context), so we are temporarily removing the `@deprecated` annotation in favor of a plain text warning until we properly fix it.

Refs #29905
Fixes FW-1336

PR Close #30514
cexbrayat added a commit to cexbrayat/angular that referenced this pull request May 29, 2019
@cexbrayat
fix(core): temporarily remove @deprecated jsdoc tag for a TextBedStat…
46abc4f 
…ic.get overload

Followup to angular#30514 which did the same for `TestBed`, but `TestBedStatic` was necessary too.
@cexbrayat cexbrayat mentioned this pull request May 29, 2019
Closed
12 tasks
AndrewKushnir pushed a commit that referenced this pull request Jun 14, 2019
@cexbrayat @AndrewKushnir
fix(core): temporarily remove @deprecated jsdoc tag for a TextBedStat…
6bc9c78 
…ic.get overload (#30714)

Followup to #30514 which did the same for `TestBed`, but `TestBedStatic` was necessary too.

PR Close #30714
AndrewKushnir pushed a commit that referenced this pull request Jun 14, 2019
@cexbrayat @AndrewKushnir
fix(core): temporarily remove @deprecated jsdoc tag for a TextBedStat…
0a7aebb 
…ic.get overload (#30714)

Followup to #30514 which did the same for `TestBed`, but `TestBedStatic` was necessary too.

PR Close #30714
@iget-master iget-master mentioned this pull request Jul 10, 2019
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

@kara kara kara approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note risk: medium target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
version 8
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cexbrayat @IgorMinar @kara @jasonaden @googlebot