fix(core): static-query migration should not fallback to test strategy #30458
+66
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently the devkit logger is not able to properly print out error objects, so we need to convert them to a string before in order to make the error visible to the user. This is not testable without an e2e test that validates the CLI terminal output.
Currently if something fails in the selected strategy (e.g. AOT failures), the migration currently accidentally falls back to the test strategy. This is not helpful as we want to give developers the possibility to re-run the migration after fixing potential AOT failures.
devversion
added
action: review
devversion
force-pushed
the
fix/static-query-improvements
branch
from
976961e to
83e1c6f
Compare
kara
removed
the
action: review
kara
added
action: merge
Slightly improves the messages for the static-query migration in order to make the terminal output less verbose but more helpful. Unfortunately we are limited in what we can print due to the devkit not providing much utilities for printing good messages from a migration schematic.
devversion
force-pushed
the
fix/static-query-improvements
branch
from
83e1c6f to
08e00a6
Compare
kara
added
merge: caretaker note
|
merge-assistance: codefresh is lagging |
alxhub
pushed a commit
that referenced
this pull request
May 14, 2019
Slightly improves the messages for the static-query migration in order to make the terminal output less verbose but more helpful. Unfortunately we are limited in what we can print due to the devkit not providing much utilities for printing good messages from a migration schematic. PR Close #30458
alxhub
pushed a commit
that referenced
this pull request
May 14, 2019
Apparently the devkit logger is not able to properly print out error objects, so we need to convert them to a string before in order to make the error visible to the user. This is not testable without an e2e test that validates the CLI terminal output. PR Close #30458
alxhub
pushed a commit
that referenced
this pull request
May 14, 2019
Slightly improves the messages for the static-query migration in order to make the terminal output less verbose but more helpful. Unfortunately we are limited in what we can print due to the devkit not providing much utilities for printing good messages from a migration schematic. PR Close #30458
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
…r#30458) Apparently the devkit logger is not able to properly print out error objects, so we need to convert them to a string before in order to make the error visible to the user. This is not testable without an e2e test that validates the CLI terminal output. PR Close angular#30458
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
angular#30458) Currently if something fails in the selected strategy (e.g. AOT failures), the migration currently accidentally falls back to the test strategy. This is not helpful as we want to give developers the possibility to re-run the migration after fixing potential AOT failures. PR Close angular#30458
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
…#30458) Slightly improves the messages for the static-query migration in order to make the terminal output less verbose but more helpful. Unfortunately we are limited in what we can print due to the devkit not providing much utilities for printing good messages from a migration schematic. PR Close angular#30458
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various improvements for the static-query migration. See individual commits