fix(core): fix interpolate identifier in AOT #30243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a regression introduced in PR 29692 where the interpolate symbol in View Engine was improperly prefixed with the ɵɵ that signifies private instructions for Ivy. It resulted in interpolations of 10+ values not working correctly in AOT mode. This commit removes the prefix.
mhevery
approved these changes
May 2, 2019
kara
added
area: core
kara
added a commit
that referenced
this pull request
May 2, 2019
This commit fixes a regression introduced in PR 29692 where the interpolate symbol in View Engine was improperly prefixed with the ɵɵ that signifies private instructions for Ivy. It resulted in interpolations of 10+ values not working correctly in AOT mode. This commit removes the prefix. PR Close #30243
sajidali
reviewed
May 15, 2019
| @@ -212,4 +212,22 @@ describe('property instructions', () => { | |||
|
|
|||
| expect(img.src.indexOf('unsafe:')).toBe(0); | |||
| }); | |||
|
|
|||
| it('should handle interpolations with 10+ values', () => { | |||
There was a problem hiding this comment.
@kara test description says 10+ values, but only checks for exactly 10 values.
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
This commit fixes a regression introduced in PR 29692 where the interpolate symbol in View Engine was improperly prefixed with the ɵɵ that signifies private instructions for Ivy. It resulted in interpolations of 10+ values not working correctly in AOT mode. This commit removes the prefix. PR Close angular#30243
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a regression introduced in PR 29692 where
the interpolate symbol in View Engine was improperly prefixed
with the ɵɵ that signifies private instructions for Ivy. It
resulted in interpolations of 10+ values not working correctly
in AOT mode. This commit removes the prefix.
(I'm unable to add a good test for AOT given the way VE tests
are set up, but I've added one for JIT).