Skip to content

fix(compiler-cli): log ngcc skipping messages as debug instead of info #30232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(compiler-cli): log ngcc skipping messages as debug instead of info #30232

wants to merge 1 commit into from
+8 −8

Conversation

filipesilva
Copy link
Contributor

@filipesilva filipesilva commented May 2, 2019 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

ngcc messages related to skipping are logged to info, which makes it hard to filter them out.

What is the new behavior?

ngcc messages related to skipping are logged to debug instead of info.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Related to angular/angular-cli#14194, angular/angular-cli#14320

Sorry, something went wrong.

@filipesilva filipesilva requested a review from a team as a code owner May 2, 2019 08:35
@filipesilva filipesilva mentioned this pull request May 2, 2019
Merged
@mary-poppins
Copy link

You can preview dbee62e at https://pr30232-dbee62e.ngbuilds.io/.

@petebacondarwin petebacondarwin added area: core Issues related to the framework runtime comp: ivy effort1: hours freq1: low action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release risk: low labels May 2, 2019
@ngbot ngbot bot added this to the needsTriage milestone May 2, 2019
@filipesilva filipesilva requested a review from a team as a code owner May 2, 2019 08:50
@mary-poppins
Copy link

You can preview 820db13 at https://pr30232-820db13.ngbuilds.io/.

@petebacondarwin petebacondarwin added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels May 2, 2019
@petebacondarwin
Copy link
Contributor

Added master and patch branches because this is important enough for CLI that it should go in 8.0.0

@kara kara added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels May 6, 2019
@kara
Copy link
Contributor

kara commented May 6, 2019 •
edited
Loading

@filipesilva This doesn't apply cleanly to the patch branch. Can you create a separate PR for the patch branch?

@kara kara closed this in 60a8888 May 6, 2019
@filipesilva filipesilva mentioned this pull request May 6, 2019
Closed
@filipesilva
Copy link
Contributor Author

@kara it's now up at #30289

kara pushed a commit that referenced this pull request May 6, 2019
@filipesilva @kara
fix(compiler-cli): log ngcc skipping messages as debug instead of info (
548b003 
#30232)

Related to angular/angular-cli#14194, angular/angular-cli#14320

PR Close #30232
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
@filipesilva @BioPhoton
fix(compiler-cli): log ngcc skipping messages as debug instead of info (
a602563 
angular#30232)

Related to angular/angular-cli#14194, angular/angular-cli#14320

PR Close angular#30232
@iget-master iget-master mentioned this pull request Jul 10, 2019
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@petebacondarwin petebacondarwin

@alan-agius4 alan-agius4

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes effort1: hours freq1: low risk: low target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@filipesilva @mary-poppins @petebacondarwin @kara @alan-agius4 @googlebot