Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router): ensure history.state is set in eager update mode #30154

Closed
wants to merge 1 commit into from
Closed

fix(router): ensure history.state is set in eager update mode #30154

wants to merge 1 commit into from

Conversation

jasonaden
Copy link
Contributor

Without this change, history.state isn't being set when updating the browser URL in eager update mode.

@jasonaden
fix(router): ensure history.state is set in eager update mode
93ad346 
Without this change, `history.state` isn't being set when updating the browser URL in `eager` update mode.
@jasonaden jasonaden requested a review from a team as a code owner April 26, 2019 18:41
@jasonaden jasonaden added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release area: router type: bug/fix labels Apr 26, 2019
@ngbot ngbot bot added this to the needsTriage milestone Apr 26, 2019
@jasonaden
Copy link
Contributor Author

Presubmit

@kara
Copy link
Contributor

kara commented May 6, 2019

@jasonaden Can you look at the TAP failures here?

@kara kara added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 6, 2019
@jasonaden jasonaden removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 6, 2019
@kara kara closed this in b40f6f3 May 6, 2019
kara pushed a commit that referenced this pull request May 6, 2019
@jasonaden @kara
fix(router): ensure history.state is set in eager update mode (#3…
9720227 
…0154)

Without this change, `history.state` isn't being set when updating the browser URL in `eager` update mode.

PR Close #30154
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
@jasonaden @BioPhoton
fix(router): ensure history.state is set in eager update mode (an…
68df181 
…gular#30154)

Without this change, `history.state` isn't being set when updating the browser URL in `eager` update mode.

PR Close angular#30154
@iget-master iget-master mentioned this pull request Jul 10, 2019
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: router cla: yes target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jasonaden @kara @mhevery @googlebot